| Summary: | Automate namespace priority order not working properly | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Martin Welk <mwelk> | |
| Component: | Automate | Assignee: | mkanoor | |
| Status: | CLOSED ERRATA | QA Contact: | Milan Falešník <mfalesni> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.5.0 | CC: | cpelland, dajohnso, jhardy, mkanoor, nachandr, obarenbo, simaishi, tfitzger | |
| Target Milestone: | GA | Keywords: | ZStream | |
| Target Release: | 5.6.0 | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | automate | |||
| Fixed In Version: | 5.6.0.1 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1326459 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-29 15:47:32 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Bug Depends On: | ||||
| Bug Blocks: | 1326459 | |||
|
Description
Martin Welk
2016-04-05 13:53:50 UTC
Created PR https://github.com/ManageIQ/manageiq/pull/7884 This error started happening since we introduced tenants and only those domains that were editable were eligible for priority ordering. All locked domains are not allowed for sorting. Since locked domains were filtered out, in the current ticket Redhat and INI-TRANS-Config had the same priority of 1. The solution is to account for the locked uneditable domains before we set the priority New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/d82851736750b10f3c598b227a0d5f709064000d commit d82851736750b10f3c598b227a0d5f709064000d Author: Madhu Kanoor <mkanoor> AuthorDate: Mon Apr 11 17:20:10 2016 -0400 Commit: Madhu Kanoor <mkanoor> CommitDate: Mon Apr 11 17:20:10 2016 -0400 Incorrect priority order of domains https://bugzilla.redhat.com/show_bug.cgi?id=1324094 With the tenant changes we only allow the user to change the priority of editable domains, when reseting the priority order the locked domains don't get accounted for and the priority values are off. app/controllers/miq_ae_class_controller.rb | 2 +- app/models/tenant.rb | 6 ++++++ spec/models/tenant_spec.rb | 18 ++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a05a6621adda1e7376c7113000d12d077c4b5fb2 commit a05a6621adda1e7376c7113000d12d077c4b5fb2 Author: Madhu Kanoor <mkanoor> AuthorDate: Mon Apr 11 17:20:10 2016 -0400 Commit: Madhu Kanoor <mkanoor> CommitDate: Tue May 24 10:12:19 2016 -0400 Incorrect priority order of domains https://bugzilla.redhat.com/show_bug.cgi?id=1324094 With the tenant changes we only allow the user to change the priority of editable domains, when reseting the priority order the locked domains don't get accounted for and the priority values are off. app/controllers/miq_ae_class_controller.rb | 2 +- app/models/tenant.rb | 6 ++++++ spec/models/tenant_spec.rb | 18 ++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) Verified in 5.6.0.8, the domains are sorted as expected. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |