| Summary: | python-pmw: Provide a Python 3 subpackage | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> |
| Component: | python-pmw | Assignee: | Tim Fenn <tim.fenn> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dkrejci, tim.fenn |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-pmw-2.0.0-1.fc24 python-pmw-2.0.0-1.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-05 04:59:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1285816 | ||
|
Description
Tomas Orsava
2016-04-05 15:05:41 UTC
Hello Tim, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html (In reply to Dominika Krejčí from comment #1) > Hello Tim, > > Do you need any help adding Python 3 support to the RPM? > > If you need more instructions, a [guide] for porting Python-based RPMs is > available. > > [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html Sure - that would be great. I'm in the process of trying to prepare an upgrade to the python-pmw package as well as incorporate these changes, but life is busy these days and I don't have much spare time! That's great to hear Tim! We'll be looking forward to it, thank you for taking the time! Finally making some progress on this. However, when I follow the guidelines I get the following error when building the package: copying Pmw/Pmw_1_3_3/bin/bundlepmw.py -> build/lib/Pmw/Pmw_1_3_3/bin + %py3_build /var/tmp/rpm-tmp.sy5yLN: line 34: fg: no job control error: Bad exit status from /var/tmp/rpm-tmp.sy5yLN (%build) Any suggestions why this is? current spec file: https://sites.google.com/site/timfenn/python-pmw.spec python-pmw-2.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ae7950e83 python-pmw-2.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8440b0a08e python-pmw-2.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ae7950e83 python-pmw-2.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8440b0a08e Hi Tim!
Could you post the whole build log? It's hard to guess from the bit you copied.
Also, I tried building it on my own from the spec file you provided and I got the following error:
...
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 /home/torsava/rpmbuild/BUILD/Pmw-2.0.0
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32s, 0 CRC32s did match.
find: 'debug': No such file or directory
+ '[' noarch = noarch ']'
+ case "${QA_CHECK_RPATHS:-}" in
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Bytecompiling .py files below /home/torsava/rpmbuild/BUILDROOT/python-pmw-2.0.0-1.fc23.x86_64/usr/lib/python2.7 using /usr/bin/python2.7
Compiling /home/torsava/rpmbuild/BUILDROOT/python-pmw-2.0.0-1.fc23.x86_64/usr/lib/python2.7/site-packages/Pmw/Pmw_2_0_0/demos/DemoVersion.py ...
File "/usr/lib/python2.7/site-packages/Pmw/Pmw_2_0_0/demos/DemoVersion.py", line 35
print('No such Pmw version', repr(version) + '.', end=' ')
That is a Python 3 syntax that isn't compatible with Python 2, it shouldn't be in a Python 2 subpackage. (Notice the file path: `/usr/lib/python2.7`.)
(In reply to Tomas Orsava from comment #9) > Hi Tim! > > Could you post the whole build log? It's hard to guess from the bit you > copied. > > Also, I tried building it on my own from the spec file you provided and I > got the following error: > > ... > + /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz > --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 > /home/torsava/rpmbuild/BUILD/Pmw-2.0.0 > /usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32s, 0 CRC32s did match. > find: 'debug': No such file or directory > + '[' noarch = noarch ']' > + case "${QA_CHECK_RPATHS:-}" in > + /usr/lib/rpm/check-buildroot > + /usr/lib/rpm/brp-compress > + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip > + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 > Bytecompiling .py files below > /home/torsava/rpmbuild/BUILDROOT/python-pmw-2.0.0-1.fc23.x86_64/usr/lib/ > python2.7 using /usr/bin/python2.7 > Compiling > /home/torsava/rpmbuild/BUILDROOT/python-pmw-2.0.0-1.fc23.x86_64/usr/lib/ > python2.7/site-packages/Pmw/Pmw_2_0_0/demos/DemoVersion.py ... > File > "/usr/lib/python2.7/site-packages/Pmw/Pmw_2_0_0/demos/DemoVersion.py", line > 35 > print('No such Pmw version', repr(version) + '.', end=' ') > > > That is a Python 3 syntax that isn't compatible with Python 2, it shouldn't > be in a Python 2 subpackage. (Notice the file path: `/usr/lib/python2.7`.) Hi Tomas! I figured out my problem (include python3-devel as a buildrequires), and was able to get a build that I *think* works appropriately now (I also had to separate out the bytecompiling for python2 and 3 modules independently to get at the issue you pointed out). But feel free to take a look and let me know what you think: http://koji.fedoraproject.org/koji/search?terms=python-pmw-2.0.0-1.fc24&type=build&match=glob Hi again, Tim! The build looks perfect, thank you for your great work! python-pmw-2.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-pmw-2.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |