Bug 1324215

rhel-osp-director: rhos7.3->8.0 upgrade of deployment with external ceph failed "Error: Could not find data item cinder_rbd_pool_name in any Hiera data file and no default supplied"

Environment:
openstack-tripleo-heat-templates-0.8.14-5.el7ost.noarch
openstack-puppet-modules-7.0.17-1.el7ost.noarch
instack-undercloud-2.2.7-2.el7ost.noarch
openstack-tripleo-heat-templates-kilo-0.8.14-5.el7ost.noarch



Steps to reproduce:

1. deploy overcloud 7.3 with external ceph
2. populate the overcloud with some objects.
3. Upgrade the overcloud (reach the last step):

openstack  overcloud deploy --templates  -e  /usr/share/openstack-tripleo-heat-templates/overcloud-resource-registry-puppet.yaml  -e  /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml  -e  /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml -e /home/stack/ssl-heat-templates/environments/puppet-ceph-external.yaml -e /home/stack/ssl-heat-templates/environments/enable-tls.yaml -e /home/stack/ssl-heat-templates/environments/inject-trust-anchor.yaml  -e  /usr/share/openstack-tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml  -e /home/stack/network-environment.yaml  -e  /usr/share/openstack-tripleo-heat-templates/environments/major-upgrade-pacemaker-converge.yaml  -e /home/stack/post.yaml


Result:
The upgrade fails:

Could not retrieve fact='apache_version', resolution='<anonymous>': undefined method `[]' for nil:NilClass\nCould not retrieve fact='apache_version', resolution='<anonymous>': undefined method `[]' for nil:NilClass\n\u001b[1;31mWarning: Scope(Class[Mongodb::Server]): Replset specified, but no replset_members or replset_config provided.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Keystone]): Execution of db_sync does not depend on $enabled anymore. Please use sync_db instead.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Keystone]): Keystone under Eventlet has been deprecated during the Kilo cycle. Support for deploying under eventlet will be dropped as of the M-release of OpenStack.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Glance::Registry]): Execution of db_sync does not depend on $manage_service or $enabled anymore. Please use sync_db instead.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_host'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_protocol'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_port'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_path'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mError: Could not find data item cinder_rbd_pool_name in any Hiera data file and no default supplied at /var/lib/heat-config/heat-config-puppet/4a776418-636c-4161-8386-0453620eb298.pp:900 on node overcloud-controller-2.localdomain\u001b[0m\n\u001b[1;31mError: Could not find data item cinder_rbd_pool_name in any Hiera data file and no default supplied at /var/lib/heat-config/heat-config-puppet/4a776418-636c-4161-8386-0453620eb298.pp:900 on node overcloud-controller-2.localdomain\u001b[0m