| Summary: | Review Request: python-toolz - A functional standard library for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-11 14:59:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Orion Poplawski
2016-04-05 22:14:53 UTC
Great that you're packaging that, it's a very nice library. I'm rather surprised that it's not in Fedora yet. There's a strange indentation in " contemporary functional languages". Can you add %global _description, and use it in the three places? The description is quite long. + license is acceptable (BSD) + license file is present, %license is used + builds and installs OK + requires and provides look sane + %python_provide is used + standard python template is used + no scriptlets present or necessary + rpmlint: only bogus spelling errors and missing documentation warnings Package is APPROVED. Thanks for the review. I'll use the global for the description. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-toolz Checked in and built. |