Bug 1324267

Just fixed my DNS settings; should be set once it gets updated.

Spec URL: http://mathstuf.fedorapeople.org/packaging/python-keyutils/python-keyutils.spec
SRPM URL: http://mathstuf.fedorapeople.org/packaging/python-keyutils/python-keyutils-0.3-1.fc25.src.rpm

OK, vhost was broken on that server and admins haven't responded yet.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues
======
[!]: Requires correct, justified where necessary.
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-keyutils , python-keyutils-debuginfo

     The main package does not require the subpackages; python2-keyutils is empty.
     The files should be contained in python2- or python3- prefixed package,
     and one of them should provide the unversioned name.
     See https://fedoraproject.org/wiki/Packaging:Python#Provides

[!]: Package meets the Packaging Guidelines::Python

     1. See above.
     2. Use macros %py2_build, %py2_install, %py3_build and %py3_install.

[!]: Latest version is packaged.

     Version 0.4 is available on PyPI.

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

     Please fix the warnings and errors.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 14 files have unknown license. Detailed output of
     licensecheck in /home/jstanek/redhat/reviews/1324267-python-
     keyutils/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-keyutils , python-keyutils-debuginfo
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-keyutils-0.3-1.fc26.x86_64.rpm
          python3-keyutils-0.3-1.fc26.x86_64.rpm
          python-keyutils-debuginfo-0.3-1.fc26.x86_64.rpm
          python-keyutils-0.3-1.fc26.src.rpm
python-keyutils.x86_64: W: spelling-error %description -l en_US infromation -> information, inflammation, confrontation
python-keyutils.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/keyutils/__init__.py 644 /usr/bin/python 
python3-keyutils.x86_64: W: spelling-error %description -l en_US infromation -> information, inflammation, confrontation
python3-keyutils.x86_64: E: non-executable-script /usr/lib64/python3.6/site-packages/keyutils/__init__.py 644 /usr/bin/python 
python-keyutils.src: W: spelling-error %description -l en_US infromation -> information, inflammation, confrontation
python-keyutils.src: W: strange-permission keyutils-0.3.tar.gz 640
python-keyutils.src: W: strange-permission python-keyutils.spec 640
python-keyutils.src: W: strange-permission keyutils-0.3-utf8-readme.patch 640
4 packages and 0 specfiles checked; 2 errors, 6 warnings.




Rpmlint (debuginfo)
-------------------
Checking: python-keyutils-debuginfo-0.3-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
python-keyutils.x86_64: W: spelling-error %description -l en_US infromation -> information, inflammation, confrontation
python-keyutils.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/keyutils/__init__.py 644 /usr/bin/python 
python3-keyutils.x86_64: W: spelling-error %description -l en_US infromation -> information, inflammation, confrontation
python3-keyutils.x86_64: E: non-executable-script /usr/lib64/python3.6/site-packages/keyutils/__init__.py 644 /usr/bin/python 
3 packages and 0 specfiles checked; 2 errors, 2 warnings.



Requires
--------
python-keyutils-debuginfo (rpmlib, GLIBC filtered):

python-keyutils (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libkeyutils.so.1()(64bit)
    libkeyutils.so.1(KEYUTILS_0.3)(64bit)
    libkeyutils.so.1(KEYUTILS_1.0)(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python3-keyutils (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libkeyutils.so.1()(64bit)
    libkeyutils.so.1(KEYUTILS_0.3)(64bit)
    libkeyutils.so.1(KEYUTILS_1.0)(64bit)
    libpthread.so.0()(64bit)
    libpython3.6m.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python-keyutils-debuginfo:
    python-keyutils-debuginfo
    python-keyutils-debuginfo(x86-64)

python-keyutils:
    python-keyutils
    python-keyutils(x86-64)
    python2.7dist(keyutils)
    python2dist(keyutils)

python3-keyutils:
    python3-keyutils
    python3-keyutils(x86-64)
    python3.6dist(keyutils)
    python3dist(keyutils)

Source checksums
----------------
https://pypi.python.org/packages/source/k/keyutils/keyutils-0.3.tar.gz :
  CHECKSUM(SHA256) this package     : 54b834a9f5518a36f48201b41ad99d1e3caf4edfdc79165b0bd35d1df4a3348d
  CHECKSUM(SHA256) upstream package : 54b834a9f5518a36f48201b41ad99d1e3caf4edfdc79165b0bd35d1df4a3348d


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1324267
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

No response on this in 2 years – closing as DEFERRED until the interest returns. Feel free to reopen if deemed necessary.