Bug 1324367
| Summary: | Review Request: libkml - Reference implementation of OGC KML 2.2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mani <manisandro> |
| Component: | Package Review | Assignee: | Roman Tsisyk <roman> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, roman |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | roman:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-30 23:53:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sandro Mani
2016-04-06 07:55:32 UTC
* Please add %{?python_provide:%python_provide python2-%{srcname}} macro:
https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro
* It would be nice to enable unit tests in %check as suggested by upstream:
> It is HIGHLY recommended that you build and run all unit tests.
https://github.com/libkml/libkml/blob/wiki/BuildingAndInstalling.md#running-the-unit-tests
https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites
* Actually, this library is a fork of original Google library,
so you can't call it "Google's reference implementation".
It makes sense to re-word %description.
>This is Google's reference implementation of OGC KML 2.2.
* You can use
Source0: https://github.com/libkml/libkml/archive/%{version}/libkml-%{version}.tar.gz
instead of
Source0: https://github.com/libkml/libkml/archive/%{version}.tar.gz
to get libkml-1.3.0.gz archive instead of 1.3.0.tar.gz
All other things are OK.
--------
+[X]: Package does not contain kernel modules.
+[X]: Package contains no static executables.
+[X]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
+[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
+[X]: License field in the package spec file matches the actual license.
+[X]: License file installed when any subpackage combination is installed.
+[X]: Package must own all directories that it creates.
+[X]: %build honors applicable compiler flags or justifies otherwise.
+[X]: Package contains no bundled libraries without FPC exception.
+[X]: Changelog in prescribed format.
+[X]: Sources contain only permissible code or content.
+[X]: Package contains desktop file if it is a GUI application.
+[X]: Development files must be in a -devel package
+[X]: Package uses nothing in %doc for runtime.
+[X]: Package consistently uses macros (instead of hard-coded directory
names).
+[X]: Package is named according to the Package Naming Guidelines.
+[X]: Package obeys FHS, except libexecdir and /usr/target.
+[X]: Spec file is legible and written in American English.
+[X]: Package is not known to require an ExcludeArch tag.
+[X]: Python eggs must not download any dependencies during the build
process.
+[X]: A package which is used by another package via an egg interface should
provide egg info.
--------
Spec URL: https://smani.fedorapeople.org/review/libkml.spec SRPM URL: https://smani.fedorapeople.org/review/libkml-1.3.0-2.fc25.src.rpm %changelog * Fri Apr 08 2016 Sandro Mani <manisandro> - 1.3.0-2 - Don't call it Google's reference implementation in Summary/Description - Update Source URL - Add python_provide macro - Enable tests Cool thing about the "archive/%{version}/libkml-%{version}.tar.gz", never saw that one before. Good job. Package is APPROVED. Thanks! If you need a review some time, feel free to ping me. libkml-1.3.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6a047959a libkml-1.3.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-37e9302a4c libkml-1.3.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-769b3cc6ff libkml-1.3.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-769b3cc6ff libkml-1.3.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. libkml-1.3.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-37e9302a4c libkml-1.3.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6a047959a libkml-1.3.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. libkml-1.3.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |