Bug 1324399

Summary: overflow scroll bars visible on the tasks tab of recipe page
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: web UIAssignee: matt jia <mjia>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: developCC: dcallagh, dowang, mjia, rjoost
Target Milestone: 23.0Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-07 23:09:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
screenshot none

Description Dan Callaghan 2016-04-06 09:17:53 UTC
Created attachment 1144130 [details]
screenshot

(only unreleased develop) Random scroll bars, see attached.

Unsetting overflow: auto; on the tab-content fixes them. Not sure why we have it there in the first place.

Comment 1 matt jia 2016-04-07 01:33:11 UTC
(In reply to Dan Callaghan from comment #0)
> Created attachment 1144130 [details]
> screenshot
> 
> (only unreleased develop) Random scroll bars, see attached.
> 
> Unsetting overflow: auto; on the tab-content fixes them. Not sure why we
> have it there in the first place.

It's because .recipe-tabs has been removed by this patch

http://gerrit.beaker-project.org/#/c/4755/

The .recipe-tabs is used to set overflow:visible on the tab-content.

On Gerrit:

   http://gerrit.beaker-project.org/#/c/4783/

Comment 2 Dan Callaghan 2016-04-07 01:46:35 UTC
Is the overflow:auto; rule coming from Bootstrap? Can we just get rid of that? When is it ever needed? Seems like we have to just keep overriding it on every tab content we have.

Comment 3 matt jia 2016-04-07 06:26:27 UTC
(In reply to Dan Callaghan from comment #2)
> Is the overflow:auto; rule coming from Bootstrap? Can we just get rid of
> that? When is it ever needed? Seems like we have to just keep overriding it
> on every tab content we have.

Yes, this rule comes from Boostrap with a comment 'prevent content from running below tabs', see line 292 in navs.less. It may be required by other boostrap components.

Comment 4 matt jia 2016-04-08 00:37:36 UTC
(In reply to matt jia from comment #1)
> On Gerrit:
> 
>    http://gerrit.beaker-project.org/#/c/4783/

Repost with correct branch

   http://gerrit.beaker-project.org/#/c/4788/

Comment 7 Dan Callaghan 2016-07-07 23:09:34 UTC
Beaker 23.0 has been released.