Bug 1324538

Summary:	lvm2 lvmdump does not collect any data
Product:	Red Hat Enterprise Linux 7	Reporter:	Branislav Náter <bnater>
Component:	sos	Assignee:	Pavel Moravec <pmoravec>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Miroslav Hradílek <mhradile>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	agk, bmr, gavin, mhradile, plambri, pmoravec, qe-baseos-apps, sbradley
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/sosreport/sos/issues/815
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1324535	Environment:
Last Closed:	2016-11-11 07:46:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1324535
Bug Blocks:

Description Branislav Náter 2016-04-06 14:51:21 UTC

Reproduced also on sos-3.2-35.el7

+++ This bug was initially created as a clone of Bug #1324535 +++

Description of problem:
When using lvmdump=on (or lvmdump-am=on) options from lvm2 plugin, expected data are not collected.

Version-Release number of selected component (if applicable):
sos-3.2-40.el6

How reproducible:
always

Steps to Reproduce:
1. sosreport -o lvm2 --tmp-dir=. --batch -k lvm2.lvmdump=on

Actual results:
no data in sos_commands/lvm2/lvmdump/ directory

Expected results:
Expected data are present

Additional info:

When running lvmdump command and providing directory where to dump data (using -d <dirname> switch), directory should not exists. Otherwise lvmdump exits with error: "Fatal: <dirname> already exists"

When running lvmdump in lvm2 plugin, get_cmd_output_path() method from __init__.py is used:

cmd = lvmdump_cmd % (lvmdump_opts,
                             self.get_cmd_output_path(name="lvmdump")) <--------
        self.add_cmd_output(cmd)

This method creates provided directory "lvmdump" and that cause lvmdump command to fails.

Fix is as easy as run get_cmd_output_path() with "make=False" argument to prevent directory creation:

cmd = lvmdump_cmd % (lvmdump_opts,
                             self.get_cmd_output_path(name="lvmdump", make=False)) <--
        self.add_cmd_output(cmd)

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-04-06 10:45:10 EDT ---

This bug report has Keywords: Regression or TestBlocker.

Since no regressions or test blockers are allowed between releases, it is also being [proposed|marked] as a blocker for this release.

Please resolve ASAP.

Comment 2 Pavel Moravec 2016-05-09 20:58:39 UTC

FYI the bug is indepentent on using --tmp-dir - reproducer is valid also for:

sosreport -o lvm2 --batch -k lvm2.lvmdump=on

Comment 5 Pavel Moravec 2016-11-11 07:46:01 UTC

This bug has been fixed due to sos rebase to 3.3 [1] that includes the upstream fix. Relevant RHEL7.3 sos errata is [2].

Therefore I am closing the bug. Please test it if it addresses the reported problem properly, and if not, reopne the BZ.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1293044
[2] https://rhn.redhat.com/errata/RHBA-2016-2380.html