Bug 1324675

Summary: puppet error when set false to NeutronEnableL3Agent
Product: Red Hat OpenStack Reporter: bigswitch <rhosp-bugs-internal>
Component: openstack-tripleo-heat-templatesAssignee: Emilien Macchi <emacchi>
Status: CLOSED ERRATA QA Contact: Toni Freger <tfreger>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.0 (Liberty)CC: emacchi, kbasil, mburns, oblaut, rhel-osp-director-maint, slinaber
Target Milestone: async   
Target Release: 8.0 (Liberty)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-0.8.14-9.el7ost Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 13:04:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description bigswitch 2016-04-06 23:10:11 UTC
Description of problem:

We are using RHOSP8 beta9. When we set NeutronEnableL3Agent to false in the environment file, a vanilla openstack deployment will fail with following error messages on the openstack controller node.

Error: Could not find dependency Pacemaker::Resource::Service[neutron-l3-agent] for Pacemaker::Constraint::Base[neutron-dhcp-agent-to-l3-agent-constraint] at /var/lib/heat-config/heat-config-puppet/ef134cbc-5127-4388-b149-7354bdab2860.pp:1414\u001b[0m\n", "deploy_status_code": 1} 

The problematic code is as following.

if hiera('neutron::enable_dhcp_agent',true) and hiera('l3_agent_service',true) {
      pacemaker::constraint::base { 'neutron-dhcp-agent-to-l3-agent-constraint':
        constraint_type => 'order',
        first_resource  => "${::neutron::params::dhcp_agent_service}-clone",
        second_resource => "${::neutron::params::l3_agent_service}-clone",
        first_action    => 'start',
        second_action   => 'start',
        require         => [Pacemaker::Resource::Service[$::neutron::params::dhcp_agent_service],
                            Pacemaker::Resource::Service[$::neutron::params::l3_agent_service]]
      }
      pacemaker::constraint::colocation { 'neutron-dhcp-agent-to-l3-agent-colocation':
        source  => "${::neutron::params::l3_agent_service}-clone",
        target  => "${::neutron::params::dhcp_agent_service}-clone",
        score   => 'INFINITY',
        require => [Pacemaker::Resource::Service[$::neutron::params::dhcp_agent_service],
                    Pacemaker::Resource::Service[$::neutron::params::l3_agent_service]]
      }
    }

The problem is that hiera 'l3_agent_service' returns nil, do I miss something or the if condition in the above code is not correct?


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Toni Freger 2016-04-19 12:27:03 UTC
Verified- all neutron agent besides l3-agent are installed and up.
****************************************************************************
Latest OSP8 from 18-Apr-2016 
openstack-tripleo-heat-templates-0.8.14-9.el7ost.noarch

****************************************************************************
Overcloud installation ran with parameter below  ( 1-controller, 1 compute):
****************************************************************************
[stack@instack ~]$ cat network.yaml 
parameter_defaults:
  NeutronEnableL3Agent: False

****************************************************************************

[stack@instack ~]$ neutron agent-list

| 00395639-c1a4-41ff-91e9-81daffffc94d | DHCP agent         | overcloud-controller-0.localdomain | :-)   | True           | neutron-dhcp-agent        |
| 3c6f4452-b90c-4dcc-b1c0-fdc00224f96c | Open vSwitch agent | overcloud-controller-0.localdomain | :-)   | True           | neutron-openvswitch-agent |
| 5d21c4cc-b038-4285-bb13-78ca0fb13ebf | Open vSwitch agent | overcloud-compute-0.localdomain    | :-)   | True           | neutron-openvswitch-agent |
| 83423e3e-9626-476c-a561-038c30b8de03 | Metadata agent     | overcloud-controller-0.localdomain | :-)   | True           | neutron-metadata-agent    |

Comment 5 errata-xmlrpc 2016-04-20 13:04:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0653.html