Bug 1324964

Summary: Add Internet Explorer support to grafana and vector webapps
Product: Red Hat Enterprise Linux 6 Reporter: Julio Entrena Perez <jentrena>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Miloš Prchlík <mprchlik>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.8CC: brolley, fche, jentrena, lberk, mbenitez, mcermak, mgoodwin, mprchlik, tlavigne
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pcp-3.10.9-8.el6 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-21 11:20:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1269194    
Attachments:
Description Flags
Grafana on IE
none
Grafana on Firefox
none
Vector on IE
none
Vector on Firefox none

Description Julio Entrena Perez 2016-04-07 17:03:05 UTC
Grafana and Vector webapps should render properly on Internet Explorer.
Internet Explorer is the defacto web browser for many of our customers and many of them are not allowed to use other web browsers.

Comment 2 Frank Ch. Eigler 2016-04-07 17:37:06 UTC
commit #dd79509e51cca in upstream pcp should fix this; a local workaround could be a web proxy that disables or re-encodes http compression.

Comment 3 Julio Entrena Perez 2016-04-08 15:22:36 UTC
Thanks Frank, the patch does not apply cleanly to pcp-3.10.9-6.el6 .
If any test builds with the backported patch are created please let me know.

Comment 4 Frank Ch. Eigler 2016-04-29 18:46:01 UTC
Julio, this request was too late to make a backport of that patch possible in RHEL6.8.  RHEL6.9 may well receive a rebase to an even newer version of pcp.  For experiment purposes, in the mean time, consider trying these new binaries:

https://bintray.com/version/files/pcp/el6/pcp/3.11.2

(Please note MSIE8 is too old to run anything serious from the pcp webapps.)

Comment 6 Frank Ch. Eigler 2016-10-26 23:35:42 UTC
Julio, my analysis in back in comment #2 was based on the assumption that you had some version of pcp >= 3.11 that showed MSIE problems.  But RHEL6.8 has only 3.10.9, so it makes sense that the subsequent compression change wouldn't backport.

So, we need to back up and try to diagnose the original problem better.  Can you advise the exact version of MSIE/Edge you need to work, and what you observed not working?  Both graphite and grafana are known not to work on very old browsers, but I hope there is another, fixable, problem.

Comment 7 Julio Entrena Perez 2016-10-31 10:30:48 UTC
Hi Frank,

The build from comment 4 works like a charm on IE11/Win7.

> Can
> you advise the exact version of MSIE/Edge you need to work, and what you
> observed not working? 

The pages for grafana and vector just don't render properly, mostly text only.
Loading these pages reveals CSS related errors in the console of IE Developer Tools.
Please see the screenshots that I'm attaching.

That said, if a rebase to 3.11.2 is planned for 6.9 then the problem is solved.

Comment 8 Julio Entrena Perez 2016-10-31 10:31:24 UTC
Created attachment 1215744 [details]
Grafana on IE

Comment 9 Julio Entrena Perez 2016-10-31 10:31:49 UTC
Created attachment 1215745 [details]
Grafana on Firefox

Comment 10 Julio Entrena Perez 2016-10-31 10:32:17 UTC
Created attachment 1215746 [details]
Vector on IE

Comment 11 Julio Entrena Perez 2016-10-31 10:32:46 UTC
Created attachment 1215747 [details]
Vector on Firefox

Comment 12 Frank Ch. Eigler 2016-10-31 12:15:21 UTC
The CSS mime-type part of the problem can be fixed with this little part of commit dd79509e51c

diff --git a/src/pmwebapi/pmresapi.cxx b/src/pmwebapi/pmresapi.cxx
index f93bdb113fff..6daa36268228 100644
--- a/src/pmwebapi/pmresapi.cxx
+++ b/src/pmwebapi/pmresapi.cxx
@@ -40,6 +40,9 @@ guess_content_type (const char *filename)
     if (0 == strcasecmp (extension, ".html")) {
         return "text/html";
     }
+    if (0 == strcasecmp (extension, ".css")) {
+        return "text/css";
+    }
     if (0 == strcasecmp (extension, ".js")) {
         return "text/javascript";
     }

(We are not expecting a pcp rebase in rhel6, considering its lifecycle.)

Comment 13 Julio Entrena Perez 2016-10-31 14:42:55 UTC
Thank you Frank, I've rebuilt 3.10.9-6 after adding the above patch and I can confirm that the patch solves the problem on Win7/IE11.

Is it being included into RHEL 6.9?

Comment 14 Frank Ch. Eigler 2016-10-31 14:45:11 UTC
Thanks for checking so quickly.  Yeah I think we can most likely get that bit backported into 6.9!

Comment 15 Frank Ch. Eigler 2016-10-31 15:20:02 UTC
(dropping "futurefeature"; code exists in rhel6 branch, just needs tweak)

Comment 18 Miloš Prchlík 2017-01-28 14:17:16 UTC
Verified with build pcp-3.10.9-9.el6.

Comment 20 errata-xmlrpc 2017-03-21 11:20:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0735.html