Bug 1325351

Summary: Review Request: perl-RDF-NS - Popular RDF name space prefixes from prefix.cc
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-RDF-NS-20150725-1.fc25 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-26 14:49:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1339244    
Bug Blocks: 1340417    

Description Petr Pisar 2016-04-08 13:41:32 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-RDF-NS/perl-RDF-NS.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-RDF-NS/perl-RDF-NS-20150725-1.fc25.src.rpm
Description:
Hard-coding URI name spaces and prefixes for RDF applications is neither
fun nor maintainable. In the end we all use more or less the same
prefix definitions, as collected at <http://prefix.cc/>. This Perl module
includes all these prefixes as defined at specific snapshots in time.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-05-26 13:08:30 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-RDF-NS-20150725-1.fc25.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(App::rdfns)
      1 perl(Carp)
      1 perl(File::ShareDir) >= 1.00
      1 perl(RDF::NS)
      1 perl(RDF::SN)
      1 perl(RDF::Trine::Node::Blank)
      1 perl(RDF::Trine::Node::Resource)
      1 perl(Scalar::Util)
      1 perl(URI)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-RDF-NS-20150725-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(App::rdfns) = 20150725
      1 perl(RDF::NS) = 20150725
      1 perl(RDF::NS::Trine) = 20150725
      1 perl(RDF::NS::URIS) = 20150725
      1 perl(RDF::SN) = 20150725
      1 perl-RDF-NS = 20150725-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-RDF-NS*
perl-RDF-NS.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-RDF-NS.src: W: spelling-error %description -l en_US http -> HTTP
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

TODO: Please add perl-generators

Please consider fixing 'TODO' items.

The package looks good.
Approved
Comment 2 Gwyn Ciesla 2016-05-26 14:25:48 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-NS
Comment 3 Petr Pisar 2016-05-26 14:49:55 UTC 
Thank you for the review and the repository.

I added the new dependency.