Bug 1325369

Summary: [TripleO] Config options in the fusor undercloud installer should have validation
Product: Red Hat Quickstart Cloud Installer Reporter: Jesus M. Rodriguez <jesusr>
Component: fusor-installerAssignee: Dylan Murray <dymurray>
Status: CLOSED ERRATA QA Contact: Tasos Papaioannou <tpapaioa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0CC: dymurray, jmatthew, joden, tcarlin, tpapaioa, tsanders
Target Milestone: gaKeywords: Triaged
Target Release: 1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1306032 Environment:
Last Closed: 2016-09-13 16:27:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1306032    
Bug Blocks: 1342594    

Description Jesus M. Rodriguez 2016-04-08 15:04:11 UTC 
The original bug identified 5 problem areas. Three of the 5 were fixed for the original bug. This clone contains the 2 remaining issues that still need to be addressed post TP3.

+++ This bug was initially created as a clone of Bug #1306032 +++

Description of problem:

Config options in the fusor undercloud installer should have validation.  Fields currently accept any and everything

Version-Release number of selected component (if applicable):

TP3

How reproducible:

100%

Steps to Reproduce:
1. Install TripleO ISO
2. Log in to run launch-fusor-undercloud-installer
3. Enter "A" for network gateway IP address

Actual results:

Traceback:
File "/usr/sbin/fusor-undercloud-configurator", line 200, in <module>
if expected_subnet[i] == inputted_subnet[i]:
IndexError: list index out of range

Expected results:

Bad values should not be accepted

Additional info:

Similarly for other input values

--- Additional comment from Tasos Papaioannou on 2016-04-04 15:28:36 EDT ---

A few issues when testing on QCIOOO-7-RHEL-7-20160401.t.3:


1.) Fixed

2.) An invalid numeric hostname is accepted:

Set your resolvable Fully Qualified Domain Name: 1.1.1
Hostname is in valid format, setting hostname

3.) An invalid DNS server IP address is accepted:

Enter the DNS nameserver's IP address to use for the Overcloud: 10.11.5.666
Nameserver IP address is valid

4.) Fixed
5.) Fixed
Comment 1 Dylan Murray 2016-07-08 18:47:02 UTC 
https://github.com/fusor/fusor-undercloud-installer/pull/41
Comment 3 John Matthews 2016-07-20 22:48:07 UTC 
QCIOOO-8.0-RHEL-7-20160719.t.0-QCIOOO-x86_64-dvd1.iso
Comment 4 Tasos Papaioannou 2016-07-21 16:24:49 UTC 
I'm still seeing the same errors mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1325369#c0 , on QCIOOO-8.0-RHEL-7-20160719.t.0:

---
2.) An invalid numeric hostname is accepted:

Set your resolvable Fully Qualified Domain Name: 1.1.1
Hostname is in valid format, setting hostname

3.) An invalid DNS server IP address is accepted:

Enter the DNS nameserver's IP address to use for the Overcloud: 10.11.5.666
Nameserver IP address is valid
----
Comment 9 Dylan Murray 2016-08-01 20:48:02 UTC 
*** Bug 1357647 has been marked as a duplicate of this bug. ***
Comment 10 John Matthews 2016-08-05 17:18:59 UTC 
Will be in compose 8/5
Comment 11 Tasos Papaioannou 2016-08-12 19:53:52 UTC 
Verified on QCIOOO-8.0-RHEL-7-20160812.t.1.
Comment 13 errata-xmlrpc 2016-09-13 16:27:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2016:1862