Bug 1325409

Summary:	[DOCS] Reserve Resources documentation is unclear
Product:	OpenShift Container Platform	Reporter:	Eric Jones <erjones>
Component:	Documentation	Assignee:	Thien-Thi Nguyen <tnguyen>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Wenjing Zheng <wzheng>
Severity:	medium	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	high
Version:	3.1.0	CC:	amelicha, aos-bugs, jchaloup, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-23 15:48:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Eric Jones 2016-04-08 18:22:41 UTC

Document URL: 
https://docs.openshift.com/enterprise/3.1/admin_guide/overcommit.html#reserving-resources-for-system-processes 

Section Number and Name: 
Reserving Resources for System Processes

Describe the issue: 
The documentation on how to implement this is very vague (how do I get the pod deployed), does not indicate if the pod will be a container on the node that is only visible by docker or if it will be a proper OSE pod, and it does not indicate what to start (service or reboot the whole node).

Suggestions for improvement: 
Clarify all of these points, and indicate what to look for if the pod is not starting.

Comment 1 Jan Chaloupka 2016-04-12 16:22:10 UTC

Have been playing with ose and trying to create the resource-reserver pod as is written in the documentation. I have not been able to have the pod created. I have dropped the yaml file under /etc/origin/node directory, restarted atomic-openshift-node.service service (many times). Nothing.

Of course, running 'oc create -f resource-reserver.yaml' will create the pod.

Maybe additional configuration of the node is required to have the running daemon read all yaml file with object specification and create them.

Comment 2 Jan Chaloupka 2016-04-12 16:54:38 UTC

Ok, node-config.yaml has to be updated. Adding:

kubeletArguments:
  config:
    - "/etc/origin/node"

will read yaml files from /etc/origin/node. Once configure, resource-reserver pod is created as well.

Comment 3 Jan Chaloupka 2016-04-12 17:04:22 UTC

Running 'oc delete resource-reserver-pod-id` will not delete the pod. If an operator wish to delete the pod, node-config.yaml has to be updated again. To e.g.

kubeletArguments:
  config:
    - ""

Or the resource-reserver.yaml has to be removed from /etc/origin/node.

Comment 4 Jan Chaloupka 2016-04-13 10:20:27 UTC

Upstream PR [1].

[1] https://github.com/openshift/openshift-docs/pull/1892

Comment 6 Thien-Thi Nguyen 2016-06-23 15:48:37 UTC

PRs merged:
https://github.com/openshift/openshift-docs/pull/1892#event-678832801
https://github.com/openshift/openshift-docs/pull/2193#event-678948098

Live:
https://docs.openshift.com/enterprise/3.2/admin_guide/overcommit.html

Moving to CLOSED CURRENTRELEASE.