| Summary: | Run *.png through zopflipng to save some space | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||||
| Component: | fedora-logos | Assignee: | Tom "spot" Callaway <tcallawa> | ||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | tcallawa | ||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-04-12 17:27:52 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
I've committed this change to upstream git for fedora-logos. Is there a need to get this into Fedora 24? It does save some space, but not a huge amount. You be the judge whether to ship it in F24, no strong opinions here. But the change applied upstream just changes the png's, it lacks the Makefile changes from my patch. (Applying it with "git am" would not have missed it, and would have also preserved authorship information... :)) Since I have the habit of wanting to review changes in patchsets manually, I did the conversion locally and then committed the change. I didn't even download the big gz version. Sorry for missing the Makefile changes. If you are willing to make those bits into a git am patch, I'll apply it properly. :) Also, since I suspect that the Makefile changes actually run zopflipng, please be sure the zopfli package with that binary is on all stable branches first. :) Created attachment 1146525 [details]
Use zopflipng, add make optimize target
Here goes the Makefile patch, just extracted from the original one.
I'm currently building zopfli with zopflipng for F-24. Not sure when or if I will do that to earlier distro versions.
Merged. Thanks. |
Created attachment 1145650 [details] Run *.png through zopflipng -m Before: $ find -name "*.png" | xargs du -cb | tail -n 1 5290526 total After: $ find -name "*.png" | xargs du -cb | tail -n 1 5086383 total "git am"able patch against upstream git attached. It's 3M+ gzipped due to image changes in it.