Bug 1325831

Summary: gluster snap status xml output shows incorrect details when the snapshots are in deactivated state
Product: [Community] GlusterFS Reporter: Avra Sengupta <asengupt>
Component: snapshotAssignee: Avra Sengupta <asengupt>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: mainlineCC: aloganat, bugs, rjoseph, storage-qa-internal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1325821
: 1369363 1369372 (view as bug list) Environment:
Last Closed: 2017-03-27 18:25:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1325821    
Bug Blocks: 1369363, 1369372    

Description Avra Sengupta 2016-04-11 10:34:06 UTC 
+++ This bug was initially created as a clone of Bug #1325821 +++

Description of problem:
gluster snap status xml output shows incorrect details when the snapshots are in deactivated state

Version-Release number of selected component (if applicable):
glusterfs-server-3.7.9-1.el7rhgs.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create a snapshot
2. Run "gluster snap status --xml"

Actual results:
gluster snap status xml output shows incorrect details

Expected results:
gluster snap status xml output should show correct information

Additional info:

CLI Output:

[root@node94 ~]# gluster snap status snap1

Snap Name : snap1
Snap UUID : a322d93a-2732-447d-ab88-b943fa402fd2

	Brick Path        :   10.70.47.11:/run/gluster/snaps/2c790e6132e447e79168d9708d4abfe7/brick1/testvol_brick0
	Volume Group      :   RHS_vg0
	Brick Running     :   No
	Brick PID         :   N/A
	Data Percentage   :   3.52
	LV Size           :   9.95g


	Brick Path        :   10.70.47.16:/run/gluster/snaps/2c790e6132e447e79168d9708d4abfe7/brick2/testvol_brick1
	Volume Group      :   RHS_vg0
	Brick Running     :   No
	Brick PID         :   N/A
	Data Percentage   :   3.52
	LV Size           :   9.95g


	Brick Path        :   10.70.47.152:/run/gluster/snaps/2c790e6132e447e79168d9708d4abfe7/brick3/testvol_brick2
	Volume Group      :   RHS_vg0
	Brick Running     :   No
	Brick PID         :   N/A
	Data Percentage   :   3.51
	LV Size           :   9.95g


	Brick Path        :   10.70.46.52:/run/gluster/snaps/2c790e6132e447e79168d9708d4abfe7/brick4/testvol_brick3
	Volume Group      :   RHS_vg0
	Brick Running     :   No
	Brick PID         :   N/A
	Data Percentage   :   3.54
	LV Size           :   9.95g

Xml Output:

[root@node94 ~]# gluster snap status --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr/>
  <snapStatus>
    <snapshots>
      <snapshot>
        <name>snap1</name>
        <uuid>a322d93a-2732-447d-ab88-b943fa402fd2</uuid>
        <volCount>1</volCount>
        <volume>
          <brickCount>4</brickCount>
          <brick>
            <path>10.70.47.11:/run/gluster/snaps/2c790e6132e447e79168d9708d4abfe7/brick1/testvol_brick0</path>
            <volumeGroup>RHS_vg0</volumeGroup>
          </brick>
        </volume>
      </snapshot>
    </snapshots>
  </snapStatus>
</cliOutput>
Comment 1 Vijay Bellur 2016-04-18 08:42:53 UTC 
REVIEW: http://review.gluster.org/14018 (snapshot/cli: Fix snapshot status xml output) posted (#1) for review on master by Avra Sengupta (asengupt)
Comment 2 Vijay Bellur 2016-08-18 07:14:19 UTC 
REVIEW: http://review.gluster.org/14018 (snapshot/cli: Fix snapshot status xml output) posted (#2) for review on master by Avra Sengupta (asengupt)
Comment 3 Worker Ant 2016-08-23 07:11:58 UTC 
COMMIT: http://review.gluster.org/14018 committed in master by Rajesh Joseph (rjoseph) 
------
commit efbae0fef5399a8826782b02140f44edaea0dac3
Author: Avra Sengupta <asengupt>
Date:   Tue Apr 12 12:26:54 2016 +0530

    snapshot/cli: Fix snapshot status xml output
    
    snap status --xml errors out if a brick is down and
    doesn't have pid. It is handled in the cli of the snap
    status where "N/A" is displayed in such a scenario.
    Handled the same in xml
    
    snap status <snapname> --xml fails as the writer is
    not initialised for the same. Using GF_SNAP_STATUS_TYPE_ITER
    instead of GF_SNAP_STATUS_TYPE_SNAP for all snap's
    status to differentiate between the two scenarios.
    
    Added testcase volume-snapshot-xml.t to check
    all snapshot commands xml outputs
    
    Change-Id: I99563e8f3e84f1aaeabd865326bb825c44f5c745
    BUG: 1325831
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/14018
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>
Comment 4 Shyamsundar 2017-03-27 18:25:08 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/