Bug 1325833

Summary: remote-viewer overrides 'admin=1' in the vv. file and still sends 'Filter: True'
Product: [Community] Virtualization Tools Reporter: Shira Maximov <mshira>
Component: virt-viewerAssignee: Daniel Berrangé <berrange>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: cfergeau, mshira, rbalakri, tjelinek, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-18 12:37:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1304755    
Attachments:
Description Flags
remote viewer debug log
none
.vv file none

Description Shira Maximov 2016-04-11 10:37:20 UTC
Created attachment 1145903 [details]
remote viewer debug log

Description of problem:
When using RHEVM, 'change CD' tab doesn't appear when openning a new VM, 
The reason is that the remote-viewer overrides 'admin=1' in the vv. file and still sends  'Filter: True'. 

the Filter: true/false means if the REST should return all the results or only the ones the particular user is allowed to see
we set the "admin: 0/1" to the .vv file so remote-viewer will know what to send
if Filter true or false

The problem is that the remote-viewer still sends it as Filter: True



Version-Release number of selected component (if applicable):
 Red Hat Enterprise Virtualization Manager Version: 3.6.5-0.1.el6 

How reproducible:
100%

Steps to Reproduce:
1. connect to RHEVM with fqdn
2. create VM and open the VM console.
3. check to see id the 'change CD' tab appear 


Actual results:


Expected results:


Additional info:

Comment 1 Tomas Jelinek 2016-04-13 06:35:18 UTC
@Christophe do you know about any changes in this regard? Because it used to work.
@Shira: what exact version of remote-viewer have you been using?

Comment 2 Christophe Fergeau 2016-04-13 11:15:01 UTC
libgovirt version would be useful too, as well as the exact .vv file which triggered the log.

Comment 3 Shira Maximov 2016-04-14 07:28:07 UTC
Created attachment 1147058 [details]
.vv file

virt-viewer-2.0-1.fc22.x86_64
libgovirt-0.3.3-1.fc22.x86_64

Comment 4 Christophe Fergeau 2016-04-14 18:07:03 UTC
virt-viewer 2.0 does not have support for the admin key in .vv files, this was added in 3.0.

Comment 5 Shira Maximov 2016-04-18 12:31:33 UTC
I upgraded my client to fedora 23, in order to have virt-viewer-3.0-1.fc23.x86_64
and now it's working fine.
you can close this bug.