Bug 1326016

Summary:	spice-server timeout after 1 million seconds
Product:	Red Hat Enterprise Linux 7	Reporter:	Joe Wright <jwright>
Component:	xorg-x11-drv-qxl	Assignee:	Default Assignee for SPICE Bugs <rh-spice-bugs>
Status:	CLOSED WONTFIX	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.2	CC:	cfergeau, dblechte, fdelorey, rbalakri, tim.briggs
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-12 12:54:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Joe Wright 2016-04-11 15:19:01 UTC

Description of problem:
- Spice remote display connection times out after exactly 1 million seconds.


Version-Release number of selected component (if applicable):
- current release

How reproducible:
- after display session open for 1 million seconds (approximately 11 1/2 days)

Steps to Reproduce:
1. Configure spice remote display using spice-server
2. connect remote display to the server
3. wait (the timer does not seem to be attached to the system clock, so forwarding the clock to the timeframe doesnt force the issue)

Actual results:
- Session timeout

Expected results:
- no session timeout

Additional info:

It appears to be in reds.c which is part of the spice-server package, according to the customer, however:

<teuf> jwright: I think here are your 1000000 seconds https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/src/spiceqxl_main_loop.c#n169
<teuf> TimerSet is /usr/include/xorg/os.h extern _X_EXPORT OsTimerPtr TimerSet(OsTimerPtr timer, int flags, CARD32 millis, OsTimerCallback func, void *arg);
<teuf> wondering if something like http://paste.fedoraproject.org/349386/78709914/ would work
<teuf> jwright: I need to go now though, I'll probably fix this upstream sometimes this week if it's something close to what I fpasted

Comment 2 Christophe Fergeau 2016-04-11 16:12:29 UTC

(In reply to Joe Wright from comment #0)
> Additional info:
> 
> It appears to be in reds.c which is part of the spice-server package,
> according to the customer

Until proven otherwise, it's a bug in an Xspice-specific part of the xorg QXL driver which is fixed by https://lists.freedesktop.org/archives/spice-devel/2016-April/028069.html

Comment 3 Tim Briggs 2016-04-11 18:01:26 UTC

(In reply to Christophe Fergeau from comment #2)
> (In reply to Joe Wright from comment #0)
> > Additional info:
> > 
> > It appears to be in reds.c which is part of the spice-server package,
> > according to the customer
> 
> Until proven otherwise, it's a bug in an Xspice-specific part of the xorg
> QXL driver which is fixed by
> https://lists.freedesktop.org/archives/spice-devel/2016-April/028069.html

The fix does appear to address the error message:
Spice-ERROR **:reds.c:3516:migrate_timeout: assertion ‘reds->mig_wait_connect || reds->mig_wait_disconnect’ failed

If someone could build test packages against RHEL 7.1, I'd be happy to verify.

Comment 4 David Blechter 2016-04-12 12:54:00 UTC

(In reply to Tim Briggs from comment #3)
> (In reply to Christophe Fergeau from comment #2)
> > (In reply to Joe Wright from comment #0)
> > > Additional info:
> > > 
> > > It appears to be in reds.c which is part of the spice-server package,
> > > according to the customer
> > 
> > Until proven otherwise, it's a bug in an Xspice-specific part of the xorg
> > QXL driver which is fixed by
> > https://lists.freedesktop.org/archives/spice-devel/2016-April/028069.html
> 
> The fix does appear to address the error message:
> Spice-ERROR **:reds.c:3516:migrate_timeout: assertion
> ‘reds->mig_wait_connect || reds->mig_wait_disconnect’ failed
> 
> If someone could build test packages against RHEL 7.1, I'd be happy to
> verify.

xspice is not supported. Please, file the bug upstream.