Bug 1326090

Summary: Catalog Item displayed in Catalog even when not selected for Display.
Product: Red Hat CloudForms Management Engine Reporter: Jeff Teehan <jteehan>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.5.0CC: cpelland, dajohnso, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: service:catalog:ui
Fixed In Version: 5.6.0.5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1331431 (view as bug list) Environment:
Last Closed: 2016-06-29 15:48:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1331431    

Description Jeff Teehan 2016-04-11 19:24:28 UTC
Description of problem:

This is minor.  When creating a catalog item for Orchestration, even thought the checkbox for display in catalog was not selected it was displayed anyway.


Version-Release number of selected component (if applicable):
5.5.3.4

How reproducible:
Always.

Steps to Reproduce:
1.  Create a catalog
2.  Create an orchestration catalog item.  (azure vm)
3.  Don't select Display in Catalog

Actual results:

You can still display it anyway.  My guess is the catalog field isn't supposed to be there until the checkbox is checked.

Expected results:

Do what the checkbox expects.

Additional info:

Comment 2 Harpreet Kataria 2016-04-27 21:35:45 UTC
https://github.com/ManageIQ/manageiq/pull/8304

Comment 3 CFME Bot 2016-04-28 16:50:52 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/54c6fdb97c68e29348f3e2950d06b5537a25826c

commit 54c6fdb97c68e29348f3e2950d06b5537a25826c
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Apr 27 17:32:59 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Apr 27 17:47:06 2016 -0400

    Do not show items not marked to be displayed in Catalog in tree
    
    Fixed Service Catalogs tree to not show items that are not marked to display in catalog. List on the right right side was already working correctly.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1326090

 app/presenters/tree_builder_service_catalog.rb     |  2 +-
 .../tree_builder_service_catalog_spec.rb           | 27 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 spec/presenters/tree_builder_service_catalog_spec.rb

Comment 4 Jeff Teehan 2016-05-12 23:36:22 UTC
This is fixed.  Tested in 5.6.0.6 on https://10.16.7.169

Moving to verified.

Comment 6 CFME Bot 2016-06-13 18:39:42 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3e03d5c1a6282de0733d1900faa64e91b97e8be4

commit 3e03d5c1a6282de0733d1900faa64e91b97e8be4
Merge: 4ef2094 23e5a16
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Jun 13 13:30:15 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Jun 13 13:30:15 2016 -0400

    Merge branch '55z_pr_8304' into '5.5.z'
    
    Do not show items not marked to be displayed in Catalog in tree
    
    Fixed Service Catalogs tree to not show items that are not marked to display in catalog. List on the right right side was already working correctly.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1326090
    https://bugzilla.redhat.com/show_bug.cgi?id=1331431
    (cherry picked from commit 54c6fdb)
    
    @dclarizi please review, clean cherry-pick for https://github.com/ManageIQ/manageiq/pull/8304
    
    See merge request !918

 app/presenters/tree_builder_service_catalog.rb     |  2 +-
 .../tree_builder_service_catalog_spec.rb           | 27 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

Comment 7 CFME Bot 2016-06-13 18:39:55 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=23e5a16bfebaf633ceeeec3509e88d2978fdbd3e

commit 23e5a16bfebaf633ceeeec3509e88d2978fdbd3e
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Apr 27 17:32:59 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Apr 28 12:55:16 2016 -0400

    Do not show items not marked to be displayed in Catalog in tree
    
    Fixed Service Catalogs tree to not show items that are not marked to display in catalog. List on the right right side was already working correctly.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1326090
    https://bugzilla.redhat.com/show_bug.cgi?id=1331431
    (cherry picked from commit 54c6fdb)

 app/presenters/tree_builder_service_catalog.rb     |  2 +-
 .../tree_builder_service_catalog_spec.rb           | 27 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 spec/presenters/tree_builder_service_catalog_spec.rb

Comment 9 errata-xmlrpc 2016-06-29 15:48:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348