Bug 1326113

Summary: anaconda fails to detect disks on 32-bit Rawhide installs
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: libbytesizeAssignee: Vratislav Podzimek <vpodzime>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: blivet-maint-list, vpodzime
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-05 00:30:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Adam Williamson 2016-04-11 21:05:15 UTC
Some time recently, openQA 32-bit Rawhide tests stopped blowing up due to a kernel error and started blowing up due to anaconda failing to detect any disks, instead.

If you look at a current openQA run - e.g. https://openqa.fedoraproject.org/tests/overview?distri=fedora&version=Rawhide&build=Fedora-Rawhide-20160411.n.0&groupid=1 - you'll see a lot of x86_64 tests pass, but all the i386 tests fail. They all fail because anaconda doesn't find any disks. In every test if you look at a screenshot of the disk selection screen, it looks like this:

https://openqa.fedoraproject.org/tests/12793/modules/disk_guided_empty/steps/3

you can grab a full set of anaconda logs from the the 'Logs & Assets' tab of any affected test. I couldn't see a really obvious smoking gun in program.log or storage.log , but maybe someone else can.

You can find image download links at https://www.happyassassin.net/nightlies.html , this bug is 32-bit only.

Comment 1 David Shea 2016-04-11 21:39:37 UTC
/dev/sda is showing up as media_present = False, and the theory on IRC is that it's the 'self.current_size > Size(0)' part of that condition. The Size(10 GB) for the disk is probably overflowing a 32-bit int and coming out negative or something.

Comment 2 Adam Williamson 2016-04-11 21:53:30 UTC
This seems to be confirmed by this test:

s = Size("10 GiB")
s > 0

returns 'False', when run on a 32-bit Rawhide image.

Comment 3 Vratislav Podzimek 2016-04-20 12:56:36 UTC
https://github.com/rhinstaller/libbytesize/pull/10

Comment 4 Vratislav Podzimek 2016-04-26 06:59:35 UTC
Merged.

Comment 5 Adam Williamson 2016-05-05 00:30:23 UTC
Confirmed this is fixed with libbytesize 0.5. (the 32-bit install seems to suddenly crash a bit later, but that's not your problem...)