Bug 1326247

Summary: FTBFS in tci.c
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: qemuAssignee: Fedora Virtualization Maintainers <virt-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: amit.shah, berrange, cfergeau, crobinso, dwmw2, itamar, pbonzini, rjones, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: s390   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-2.6.0-0.1.rc2.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 15:25:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Dan Horák 2016-04-12 09:02:06 UTC
build on s390 (haven't checked s390x yet) fails with

...
cc -I/builddir/build/BUILD/qemu-2.6.0-rc1/tcg -I/builddir/build/BUILD/qemu-2.6.0-rc1/tcg/tci -I/builddir/build/BUILD/qemu-2.6.0-rc1/linux-headers -I/builddir/build/BUILD/qemu-2.6.0-rc1/linux-headers -I. -I/builddir/build/BUILD/qemu-2.6.0-rc1 -I/builddir/build/BUILD/qemu-2.6.0-rc1/include -I/builddir/build/BUILD/qemu-2.6.0-rc1 -I. -I/usr/include/pixman-1  -DHAS_LIBSSH2_SFTP_FSYNC -fPIE -DPIE -m31 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common  -O2  -pipe -Wall -Werror=format-security -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m31 -march=z9-109 -mtune=z10 -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1    -I/usr/include/libpng16 -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libusb-1.0   -I../linux-headers -I.. -I/builddir/build/BUILD/qemu-2.6.0-rc1/target-i386 -DNEED_CPU_H -I/builddir/build/BUILD/qemu-2.6.0-rc1/include -MMD -MP -MT tci.o -MF ./tci.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -c -o tci.o /builddir/build/BUILD/qemu-2.6.0-rc1/tci.c
In file included from /builddir/build/BUILD/qemu-2.6.0-rc1/include/qemu/osdep.h:80:0,
                 from /builddir/build/BUILD/qemu-2.6.0-rc1/tci.c:20:
/builddir/build/BUILD/qemu-2.6.0-rc1/tci.c: In function 'tcg_qemu_tb_exec':
/builddir/build/BUILD/qemu-2.6.0-rc1/tci.c:528:30: error: 'old_code_ptr' undeclared (first use in this function)
             assert(tb_ptr == old_code_ptr + op_size);
                              ^
/builddir/build/BUILD/qemu-2.6.0-rc1/tci.c:528:30: note: each undeclared identifier is reported only once for each function it appears in
/builddir/build/BUILD/qemu-2.6.0-rc1/tci.c:528:45: error: 'op_size' undeclared (first use in this function)
             assert(tb_ptr == old_code_ptr + op_size);
                                             ^
/builddir/build/BUILD/qemu-2.6.0-rc1/rules.mak:57: recipe for target 'tci.o' failed
make[1]: Leaving directory '/builddir/build/BUILD/qemu-2.6.0-rc1/i386-softmmu'
make[1]: *** [tci.o] Error 1
...

for full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2181716


Version-Release number of selected component (if applicable):
qemu-2.6.0-0.1.rc1.fc24

Comment 1 Cole Robinson 2016-04-12 13:00:07 UTC
2.6.0-rc2 should be out today, that should fix it with:

commit 3ccdbecf80a322a31dbf452d433321c67f82d534
Author: Stefan Weil <sw>
Date:   Tue Apr 5 22:24:51 2016 +0200

    tci: Fix build regression

Comment 2 Fedora Update System 2016-04-15 10:18:20 UTC
qemu-2.6.0-0.1.rc2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6b322b8088

Comment 3 Fedora Update System 2016-04-15 23:22:04 UTC
qemu-2.6.0-0.1.rc2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6b322b8088

Comment 4 Fedora Update System 2016-04-20 15:25:30 UTC
qemu-2.6.0-0.1.rc2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.