Bug 1326266

Summary: virt-v2v should prevent multiple conflicting for "-oa "
Product: Red Hat Enterprise Linux 7 Reporter: keanli <keanli>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: mxie, mzhan, ptoscano, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: V2V
Fixed In Version: libguestfs-1.32.4-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 17:59:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
convert with multiple conflicting log none

Description keanli 2016-04-12 09:47:44 UTC
Created attachment 1146301 [details]
convert with multiple conflicting log

Description of problem:
Virt-v2v can't show any error notification to user when using virt-v2v convert a guest with multiple conflicting for "-oa"


Version-Release number of selected component (if applicable):

virt-v2v-1.32.3-1.el7.x86_64
libguestfs-1.32.3-1.el7.x86_64
libvirt-1.3.3-1.el7.x86_64
qemu-kvm-1.5.3-109.el7.x86_64


How reproducible:
100%

Steps to Reproduce:

1.Convert a guest with multiple conflicting option "-oa" from local to rhevm  using virt-v2v 
#virt-v2v -o rhev -os 10.73.2.1:/home/nfs_export -of raw rhel6.6 -oa sparse -n ovirtmgmt -oa sparse -oa preallocated  -oa sparse

Actual results:
1,There is no error notification to user on the command line 
## virt-v2v -o rhev -os 10.73.2.1:/home/nfs_export -of raw rhel6.6 -oa sparse -n ovirtmgmt -oa sparse -oa preallocated  -oa sparse 
[   0.0] Opening the source -i libvirt rhel6.6
[   0.0] Creating an overlay to protect the source from being modified
[   0.4] Initializing the target -o rhev -os 10.73.2.1:/home/nfs_export
virt-v2v: warning: cannot write files to the NFS server as 36:36, even 
though we appear to be running as root. This probably means the NFS client 
or idmapd is not configured properly.

You will have to chown the files that virt-v2v creates after the run, 
otherwise RHEV-M will not be able to import the VM.
[   0.5] Opening the overlay
[   5.0] Inspecting the overlay
[  17.1] Checking for sufficient free disk space in the guest
[  17.1] Estimating space required on target for each disk
[  17.1] Converting Red Hat Enterprise Linux Server release 6.6 (Santiago) to run on KVM
virt-v2v: This guest has virtio drivers installed.
[  79.5] Mapping filesystem data to avoid copying unused and blank areas
[  79.8] Closing the overlay
[  80.0] Checking if the guest needs BIOS or UEFI to boot
[  80.0] Assigning disks to buses
[  80.0] Copying disk 1/1 to /tmp/v2v.p2TQIT/7786f4e5-b04e-44e4-b909-363566201ffa/images/19a608ad-8dba-486b-b118-4e7bf775246e/47a1e159-3205-4cc3-a373-0fb59809f2be (raw)
    (100.00/100%)
[ 136.6] Creating output metadata
[ 136.7] Finishing off

2,The latest "-oa " output will be execute  

Expected results:
virt-v2v should be prevent the multiple conflicting for "-oa", and give to user a error notification, like below notification:

virt-v2v: error: -on option used more than once on the command line

If reporting bugs, run virt-v2v with debugging enabled and include the 
complete output:

  virt-v2v -v -x [...]


Additional info:
The guest which convert with multiple conflicting for "-oa" can be boot and meet all checkpoint

Comment 2 keanli 2016-04-12 10:27:23 UTC
Lost two bug : duplicate --root, -v ,-x 
It's also no error notification show to  user on command line !

Comment 3 Richard W.M. Jones 2016-04-12 10:48:53 UTC
Thanks - I fixed this upstream in
https://github.com/libguestfs/libguestfs/commit/fc4936661d7a5150208f8fb9ba0c31ae218c38b5

(In reply to keanli from comment #2)
> Lost two bug : duplicate --root, -v ,-x 
> It's also no error notification show to  user on command line !

I don't really think these are a bug, but in any case,
each issue needs to have a separate bug.

Comment 5 keanli 2016-04-28 09:56:01 UTC
I can reproduce it with builds:
libguestfs-1.32.3-1.el7.x86_64
virt-v2v-1.32.3-1.el7.x86_64

Verifiy it with builds:
libguestfs-1.32.4-1.el7.x86_64
Virt-v2v-1.32.4-1.el7.x86_64

Steps:
1,Convert a guest with multiple conflicting option "-oa" using virt-v2v
#virt-v2v -ic xen+ssh://10.73.3.21 rhel6.6 -of raw -oa sparse -oa sparse
virt-v2v: error: -oa option used more than once on the command line
If reporting bugs, run virt-v2v with debugging enabled and include the
complete output:
virt-v2v -v -x [...]

Result Now:
The virt-v2v can prevent multiple option "-oa" well, so the bug is fixed
 
So move the bug form ON_QA to VERIFIED

Comment 9 errata-xmlrpc 2016-11-03 17:59:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html