Bug 1326521

Summary: Review Request: php-akamai-open-edgegrid-client - Implements the Akamai {OPEN} EdgeGrid Authentication
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: fedora: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-30 23:53:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2016-04-12 22:07:11 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ae567ce0484ed392a5946043a9a3b199a10d058a/php-akamai-open-edgegrid-client/php-akamai-open-edgegrid-client.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-akamai-open-edgegrid-client-0.4.4-1.fc23.src.rpm

Description:
Akamai {OPEN} EdgeGrid Authentication [1] for PHP

This library implements the Akamai {OPEN} EdgeGrid Authentication scheme on top
of Guzzle, as both a drop-in replacement client, and middleware.

For more information visit the Akamai {OPEN} Developer Community [2].

Autoloader: /usr/share/php/Akamai/Open/EdgeGrid/autoload.php

[1] https://developer.akamai.com/introduction/Client_Auth.html
[2] https://developer.akamai.com/

NOTE: CLI not packaged on purpose


Fedora Account System Username: siwinski

Comment 1 Remi Collet 2016-04-14 14:33:32 UTC
Created attachment 1147268 [details]
phpci.log

     Note: phpCompatInfo version 5.0.0 DB version 1.7.0 built Apr 12 2016
     08:25:26 CEST static analyze results

Comment 2 Remi Collet 2016-04-14 14:34:01 UTC
Created attachment 1147269 [details]
review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1326521
Buildroot used: fedora-rawhide-x86_64

Comment 3 Remi Collet 2016-04-14 14:36:21 UTC
Everything seems ok.

Perhaps src/CLI.php and bin/http which are not installed can be packaged in %doc


=== APPROVED ===

Comment 4 Shawn Iwinski 2016-04-14 17:19:53 UTC
THANKS for the review!  SCM request opened in pkgdb.

For a little background on why the CLI wasn't packaged, see https://github.com/akamai-open/AkamaiOPEN-edgegrid-php/issues/26

Comment 5 Till Maas 2016-04-14 21:47:33 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-akamai-open-edgegrid-client

Comment 6 Fedora Update System 2016-04-15 14:08:10 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4c43492ba8

Comment 7 Fedora Update System 2016-04-15 14:08:17 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-556664b74f

Comment 8 Fedora Update System 2016-04-15 23:21:26 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-556664b74f

Comment 9 Fedora Update System 2016-04-20 15:25:08 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-04-22 20:58:21 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4c43492ba8

Comment 11 Fedora Update System 2016-04-30 23:53:24 UTC
php-akamai-open-edgegrid-client-0.4.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.