Bug 1326633

Summary: Missing notifications for (un)successful bookmark creation
Product: Red Hat Satellite Reporter: Andrii Balakhtar <abalakht>
Component: SearchAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED WORKSFORME QA Contact: Katello QA List <katello-qa-list>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: abalakht, bbuckingham, bkearney, tomckay, walden
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/17788
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-20 13:42:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Error shown when adding bookmark without a name. none

Description Andrii Balakhtar 2016-04-13 09:11:17 UTC 
Description of problem:
When creating a bookmark, after hitting the 'Submit' button no notification messages appear, making user not sure whether the creation was actually successful. It's especially confusing when validation happened (e.g. user forgot to input bookmark name) and bookmark wasn't actually created - modal form just closes and that's it, and user has to manually navigate to bookmarks list and check whether the bookmark was created.

Version-Release number of selected component (if applicable):
Satellite 6.2 Beta Snap 7.1

How reproducible:
Always

Steps to Reproduce:
1. Navigate to any page with a search box (e.g., Hosts -> Operating Systems)
2. Successfully create any search bookmark, check notification message.
3. Fail to create any search bookmark (e.g., leave 'Name' field empty), check notification message.

Actual results:
Notifications for both successful and unsuccessful bookmark creation are missing.

Expected results:
Notifications should appear for both successful and unsuccessful bookmark creation.

Additional info:
There're 2 bookmark creation forms. Examples are form on Hosts -> Operating Systems and Content -> Products. Need to ensure notifications were added to both kinds of pages.
Comment 2 Brad Buckingham 2016-04-14 16:38:17 UTC 
With Snap 8, I see the behaviors below.

When creating a bookmark successfully, there is a flash notification on the upper right hand side of the browser displaying the message below.  The notification is only temporary (~ 5 seconds)

"Success: Bookmark was successfully created."

When attempting to create a bookmark without a required field (e.g. without a 'name'), I am redirected to a new bookmark form that shows the name was not included.  I am attaching a screenshot of that aspect.

Are you not seeing either of these on your configuration? 

If not, what browser version are you using?
Comment 3 Brad Buckingham 2016-04-14 16:38:59 UTC 
Created attachment 1147280 [details]
Error shown when adding bookmark without a name.
Comment 4 Andrii Balakhtar 2016-04-14 19:43:50 UTC 
My bad. I was under impression that bookmarks created from search box of both styles are affected by this issue, but it appears only 'katello-style' searchbox is affected.
Try it on different pages - like Content -> Products or Content -> Activation Keys. The bookmark creation form is different there, and it acts just like reported here - no notifications for success or failure and no redirects, form just closes and that's it.
Comment 5 Brad Buckingham 2016-04-14 20:56:15 UTC 
Andrii, Thanks for the clarification.  I see the issues you are referring to now.
Comment 6 Walden Raines 2016-12-19 22:06:47 UTC 
Created redmine issue http://projects.theforeman.org/issues/17788 from this bug
Comment 7 Bryan Kearney 2017-03-06 22:35:06 UTC 
Walden, upstream says this can not be reproduced. Are you still seeing it?
Comment 8 Walden Raines 2017-03-20 13:42:05 UTC 
(In reply to Bryan Kearney from comment #7)
> Walden, upstream says this can not be reproduced. Are you still seeing it?

No I'm not, going to close.