Bug 1326642

Summary:	The IMAGE_VERSION is not the value we specified by openshift_image_tag
Product:	OpenShift Container Platform	Reporter:	Anping Li <anli>
Component:	Cluster Version Operator	Assignee:	Devan Goodwin <dgoodwin>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	medium	Docs Contact:
Priority:	high
Version:	3.2.0	CC:	aos-bugs, bleanhar, dgoodwin, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-07 10:55:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Anping Li 2016-04-13 09:26:28 UTC

Description of problem:
Openshift ansible is using g_aos_versions.avail_version to set VERSION in sysconfig files. however, if we specify openshift_image_tag, the target version values is stored in g_new_version.


Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.0.79-1.git.0.9c75f11.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. install containerlized OSE 3.1
2. set openshift_image_tag to a value which is different with the latest in inventory file
   For example: if openshift3/ose:latest=openshift3/ose:v3.2.0.14, we set openshift_image_tag=v3.2.0.12
3. upgrade to OSE3.2 using ansible-playbook
4. check the VERSION under /etc/sysconfig/atomic-openshift-* /etc/sysconfig/openvswitch
   grep VERSION /etc/sysconfig/atomic-openshift* /etc/sysconfig/openvswitch


Actual results:
4. grep VERSION /etc/sysconfig/atomic-openshift* /etc/sysconfig/openvswitch
/etc/sysconfig/atomic-openshift-master:IMAGE_VERSION=v3.2.0.14
/etc/sysconfig/atomic-openshift-master-api:IMAGE_VERSION=v3.2.0.14
/etc/sysconfig/atomic-openshift-master-controllers:IMAGE_VERSION=v3.2.0.14
/etc/sysconfig/atomic-openshift-node:IMAGE_VERSION=v3.2.0.14
/etc/sysconfig/openvswitch:IMAGE_VERSION=v3.2.0.14



Expected results:
The IMAGE_VERSION should be same with openshift_image_tag

Additional info:

Comment 1 Anping Li 2016-04-13 11:14:00 UTC

please also notice that openshift_container_versions.sh was ran before docker new options take affect. so we couldn't get the VERSION from the new added registry.

Comment 2 Devan Goodwin 2016-04-18 18:17:08 UTC

I think this is still happening even using latest master and Sam's branch.

Using a private registry with 3.2.0.14 and 3.2.0.16 pushed to it, and in my inventory:

openshift_image_tag=v3.2.0.14

After running upgrade:

bash-4.2# grep VERSION /etc/sysconfig/atomic-openshift* /etc/sysconfig/openvswitch
/etc/sysconfig/atomic-openshift-master:IMAGE_VERSION=v3.2.0.16
/etc/sysconfig/atomic-openshift-node:IMAGE_VERSION=v3.2.0.16
/etc/sysconfig/openvswitch:IMAGE_VERSION=v3.2.0.16

Comment 3 Devan Goodwin 2016-04-20 17:42:05 UTC

Fixed and merged in: https://github.com/openshift/openshift-ansible/pull/1781

Comment 5 Anping Li 2016-05-17 07:54:32 UTC

The bug fixed, so moved to verified.

Comment 7 errata-xmlrpc 2016-06-07 10:55:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1208