Bug 1326758

Summary: AFSK does not work at bit-rates lower than 1200 baud
Product: [Fedora] Fedora Reporter: g.trentalancia
Component: soundmodemAssignee: Lucian Langa <lucilanga>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 23CC: g.trentalancia, lucilanga
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-20 19:56:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Proposed patch (1/2)
none
Proposed patch (2/2) none

Description g.trentalancia 2016-04-13 12:05:30 UTC
Created attachment 1146830 [details]
Proposed patch (1/2)

Description of problem:

The AFSK modem does not work at bit-rates lower than 1200 baud (e.g. 300 baud for HF operation).

Version-Release number of selected component (if applicable):

All versions at least from 0.16 up to the latest version.

How reproducible:

Always.

Steps to Reproduce:
1. Configure the AFSK modem speed to be lower than 1200 baud (for example, 300 baud): it's the parameter called "bps" in the soundmodem.conf configuration file
2. (Re-)Start soundmodem
3. Reception and transmission is impossible

Actual results:

Reception and/or transmission is not possible (nothing is received and/or transmitted data cannot be received by others).

Expected results:

Reception and transmission should work normally as for bit-rates greater or equal to 1200 baud.

Additional info:

A set of two patches is proposed. The patches have been tested extensively and they also improve reception at all bit-rates.

Comment 1 g.trentalancia 2016-04-13 12:06:31 UTC
Created attachment 1146833 [details]
Proposed patch (2/2)

Comment 2 Fedora End Of Life 2016-11-25 07:20:49 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2016-12-20 19:56:36 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.