Bug 1326829

Summary: Update HE VM memory value show error message connect to memory hotplug
Product: [oVirt] ovirt-engine Reporter: Artyom <alukiano>
Component: BLL.HostedEngineAssignee: Yanir Quinn <yquinn>
Status: CLOSED CURRENTRELEASE QA Contact: Nikolai Sednev <nsednev>
Severity: low Docs Contact:
Priority: high    
Version: 3.6.5CC: alukiano, bugs, dfediuck, mavital, mgoldboi, michal.skrivanek, rgolan, ylavi, yquinn
Target Milestone: ovirt-4.0.0-rcKeywords: Triaged
Target Release: 4.0.0Flags: rule-engine: ovirt-3.6.z+
mgoldboi: planning_ack+
rgolan: devel_ack+
mavital: testing_ack+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:49:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
engine log none

Description Artyom 2016-04-13 13:33:56 UTC
Created attachment 1146855 [details]
engine log

Description of problem:
Update HE VM memory value show error message:
Message: Failed to hot set memory to VM HostedEngine. Underlying error message: Hot un-plugging memory is not supported for cluster version 3.6 and architecture x86_64, also when I want to update HE VM memory only on next run.

Version-Release number of selected component (if applicable):
rhevm-3.6.5.3-0.1.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Deploy HE and add storage domain to engine to start auto-import procedure
2. Edit HE VM memory value
3.

Actual results:
Engine show error message Failed to hot set memory to VM HostedEngine. Underlying error message: Hot un-plugging memory is not supported for cluster version 3.6 and architecture x86_64, also when I want to update HE VM memory only on next run.
On next run, HE VM has new memory value

Expected results:
On next run, HE VM has new memory value without any error message under engine

Additional info:

Comment 1 Martin Sivák 2016-04-13 15:34:02 UTC
We do display the error, because I was asked to do it like that instead of blocking the hotplug attempt completely. But the memory edit itself worked fine if I understand you correctly.

Comment 2 Artyom 2016-04-13 16:07:13 UTC
yes correct, if you say error message is desired behaviour you can close this bug, but for me, it looks unclear

Comment 3 Martin Sivák 2016-04-13 16:15:18 UTC
It might not be desired, but it is expected. I will let PMs decide about how confusing that is.

Comment 4 Moran Goldboim 2016-04-13 18:21:56 UTC
hot remove should be blocked on any level, hot add mem should be blocked on hosted engine for now.
was the action hot add or hot remove memory?

Comment 5 Martin Sivák 2016-04-13 21:33:10 UTC
Moran, the engine always attempts hotplug for hosted engine VM, but handles the failure gracefully by also saving the updated memory size to the hosted engine configuration store.

The only issue here is that we still show the error to the user.

Comment 6 Michal Skrivanek 2016-04-14 04:54:47 UTC
It's inconsistent with regular VMs. Unplug should have been prevented in UI

Comment 7 Roy Golan 2016-04-17 07:13:29 UTC
(In reply to Michal Skrivanek from comment #6)
> It's inconsistent with regular VMs. Unplug should have been prevented in UI

There is no unplug in the UI, just increase or decrease, and if you VM is up the action would attempt hot add/remove.

We can add a support config value around the call which is 'false' that will prevent the hot add actions on hosted engine and open it up using a setup plugin when its supported

Comment 8 Red Hat Bugzilla Rules Engine 2016-04-20 12:06:47 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 9 Michal Skrivanek 2016-05-18 10:42:49 UTC
(In reply to Roy Golan from comment #7)
> (In reply to Michal Skrivanek from comment #6)
> > It's inconsistent with regular VMs. Unplug should have been prevented in UI
> 
> There is no unplug in the UI, just increase or decrease, and if you VM is up
> the action would attempt hot add/remove.
> 
> We can add a support config value around the call which is 'false' that will
> prevent the hot add actions on hosted engine and open it up using a setup
> plugin when its supported

yes. I meant for the decrease. There is such config for regular VMs, it should either be applied the same on HE or a new config value can be created just for HE

Sicne there is really nothing special in this case for HE we should be able to use the existing config option

Comment 10 Yaniv Lavi 2016-06-15 12:46:55 UTC
We do not do hot plug in 3.6 and this is the same for 4.0, please test that nothing changed.

Comment 15 Nikolai Sednev 2016-06-16 10:39:48 UTC
Changed from 4096MB to 5120MB without any errors.
After changes propagated to HE-VM's configuration and engine was restarted, it received 5120MB as required. 
Engine:
ovirt-engine-setup-plugin-ovirt-engine-4.0.0.2-0.1.el7ev.noarch
ovirt-vmconsole-1.0.3-1.el7ev.noarch
ovirt-engine-extension-aaa-jdbc-1.1.0-1.el7ev.noarch
rhevm-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-setup-base-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-websocket-proxy-4.0.0.2-0.1.el7ev.noarch
ovirt-image-uploader-4.0.0-1.el7ev.noarch
ovirt-engine-backend-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-tools-4.0.0.2-0.1.el7ev.noarch
rhevm-guest-agent-common-1.0.12-1.el7ev.noarch
ovirt-engine-lib-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-dwh-setup-4.0.0-2.el7ev.noarch
ovirt-log-collector-4.0.0-1.el7ev.noarch
rhevm-branding-rhev-4.0.0-0.0.master.20160531161414.el7ev.noarch
ovirt-engine-vmconsole-proxy-helper-4.0.0.2-0.1.el7ev.noarch
ovirt-host-deploy-java-1.5.0-1.el7ev.noarch
ovirt-engine-dbscripts-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-4.0.0.2-0.1.el7ev.noarch
rhev-guest-tools-iso-4.0-2.el7ev.noarch
ovirt-engine-setup-plugin-websocket-proxy-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-tools-backup-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-userportal-4.0.0.2-0.1.el7ev.noarch
rhev-release-4.0.0-12-001.noarch
ovirt-engine-setup-4.0.0.2-0.1.el7ev.noarch
ovirt-vmconsole-proxy-1.0.3-1.el7ev.noarch
rhevm-dependencies-4.0.0-1.el7ev.noarch
ovirt-engine-restapi-4.0.0.2-0.1.el7ev.noarch
rhevm-setup-plugins-4.0.0-1.el7ev.noarch
ovirt-engine-cli-3.6.2.0-1.el7ev.noarch
rhevm-doc-4.0.0-2.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-extensions-api-impl-4.0.0.2-0.1.el7ev.noarch
ovirt-iso-uploader-4.0.0-1.el7ev.noarch
ovirt-engine-webadmin-portal-4.0.0.2-0.1.el7ev.noarch
ovirt-engine-dwh-4.0.0-2.el7ev.noarch
ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.0.0.2-0.1.el7ev.noarch
ovirt-host-deploy-1.5.0-1.el7ev.noarch
ovirt-setup-lib-1.0.2-1.el7ev.noarch
ovirt-engine-sdk-python-3.6.5.0-1.el7ev.noarch
Linux version 3.10.0-327.22.2.el7.x86_64 (mockbuild.eng.bos.redhat.com) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) ) #1 SMP Thu Jun 9 10:09:10 EDT 2016
Linux 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 9 10:09:10 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux Server release 7.2 (Maipo)

Host:
mom-0.5.4-1.el7ev.noarch
ovirt-vmconsole-1.0.3-1.el7ev.noarch
sanlock-3.2.4-2.el7_2.x86_64
libvirt-client-1.2.17-13.el7_2.5.x86_64
qemu-kvm-rhev-2.3.0-31.el7_2.15.x86_64
vdsm-4.18.1-11.gita92976e.el7ev.x86_64
ovirt-hosted-engine-setup-2.0.0-1.el7ev.noarch
ovirt-host-deploy-1.5.0-1.el7ev.noarch
ovirt-hosted-engine-ha-2.0.0-1.el7ev.noarch
ovirt-setup-lib-1.0.2-1.el7ev.noarch
ovirt-vmconsole-host-1.0.3-1.el7ev.noarch
ovirt-engine-sdk-python-3.6.5.0-1.el7ev.noarch
Linux version 3.10.0-327.22.2.el7.x86_64 (mockbuild.eng.bos.redhat.com) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) ) #1 SMP Thu Jun 9 10:09:10 EDT 2016
Linux 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 9 10:09:10 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux Server release 7.2 (Maipo)

Comment 16 Sandro Bonazzola 2016-07-05 07:49:42 UTC
oVirt 4.0.0 has been released, closing current release.