Bug 1326841

Summary: mod_revocator leaks semaphores
Product: Red Hat Enterprise Linux 6 Reporter: Martin Poole <mpoole>
Component: mod_revocatorAssignee: Matthew Harmsen <mharmsen>
Status: CLOSED ERRATA QA Contact: Kaleem <ksiddiqu>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.7CC: akasurde, chorn, knoha, ksiddiqu, mharmsen, moshiro, msugaya, tlavigne, yoguma
Target Milestone: rc   
Target Release: 6.9   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mod_revocator-1.0.3-11.el6 Doc Type: Bug Fix
Doc Text:
When mod_revocator was enabled in httpd, every time httpd was stopped, mod_revocator leaked a semaphore. The provided patch fixes this issue, and mod_revocator no longer leaks semaphores upon httpd shutdowns. [BZ #1326841]
 Story Points: ---
Clone Of: 1326840 Environment:
Last Closed: 2017-03-21 09:07:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1326840, 1364560, 1364561    
Bug Blocks: 1269194, 1400664, 1405173    
Attachments:
Description Flags
console.log none

Description Martin Poole 2016-04-13 13:55:38 UTC 
+++ This bug was initially created as a clone of Bug #1326840 +++

Description of problem:

mod_revocator leaks a semaphore every time httpd stops
 
Version-Release number of selected component (if applicable):

mod_revocator-1.0.3-10.el6.x86_64

How reproducible:

always

Steps to Reproduce:
1. restart httpd a few times
2.
3.

Actual results:

number of semaphores owned by apache increases

Expected results:

steady state.

Additional info:

The only instance of marking the semaphore for removal is in the shutdown of crlhelper.  If the helper is not enabled, or even if it is there is no assurance that it will reach the end of the main block before being killed by its parent.

The main code contains the comment

    /* The semaphore is removed in the helper program. This is because that
     * program survives Apache reloads so the semaphore will as well.
     */

but again does not take account of shutdowns.
Comment 3 Abhijeet Kasurde 2016-11-29 06:51:05 UTC 
Verified using mod_revocator version:

mod_revocator-1.0.3-11.el6.x86_64

Please find the attachment as verification steps. Marking BZ as verified.
Comment 4 Abhijeet Kasurde 2016-11-29 06:52:05 UTC 
Created attachment 1225636 [details]
console.log
Comment 6 errata-xmlrpc 2017-03-21 09:07:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0577.html