Bug 1326968

Summary:	[RFE] link to recipe in notification e-mail
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	general	Assignee:	Blake McIvor <bmcivor>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	develop	CC:	bmcivor, dcallagh, dowang, mjia, rjoost
Target Milestone:	23.0	Keywords:	EasyFix, FutureFeature, Patch, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-07 23:11:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2016-04-14 00:06:10 UTC

Currently the job completion notification e-mail has a link to the job but not to any recipes. Now that the new job page does not show any results, you have to click through to the recipe to see them.

This is particularly noticeable on single-host jobs where the job page doesn't tell you anything much interesting, you end up just clicking through to the recipe straight away.

If we link to each individual recipe in the notification e-mail then people can go straight to the results of whichever recipe they are interested in.

Comment 1 Blake McIvor 2016-05-17 06:04:30 UTC

this could either be completed by changing failed_recipes to handle both successful and is_failed recipes

leaving just a simple call to the body component of send_mail but, will require re-factoring where it is called in test_reporting_queries.py (also used in install-failure-count-by-resource.sql) 

OR

simply write another helper function which is also called in the body of send_mail

Comment 2 Dan Callaghan 2016-05-18 18:13:32 UTC

Blake, not sure exactly which piece of code you are looking at but this shouldn't require any refactoring... The notification mail already contains a line for each failed recipe. This bug is just about appending a link to the end of that.

Here's an example from dogfood:

JobID: 9759 Status: Completed Result: Fail <https://beaker-devel.app.eng.bos.redhat.com/jobs/9759>
    RecipeSetID: 12470
        RecipeID: 14304 Arch: x86_64 System: dev-kvm-guest-10.rhts.eng.bos.redhat.com Distro: RHEL-6.7-20150702.0 OSVersion: RedHatEnterpriseLinux6.7 Status: Completed Result: Fail
            TaskID: 133458 TaskName: /distribution/beaker/dogfood StartTime: 2016-05-16 03:04:52 Duration: 2:37:50 Status: Completed Result: Fail

We can probably drop the OSVersion to save some space, since it's redundant with Distro. So the recipe line would be:

        RecipeID: 14304 Arch: x86_64 System: dev-kvm-guest-10.rhts.eng.bos.redhat.com Distro: RHEL-6.7-20150702.0 Status: Completed Result: Fail <https://beaker-devel.app.eng.bos.redhat.com/recipes/14304>

Comment 3 Blake McIvor 2016-05-23 06:20:53 UTC

some classic over-thinking there, I was thinking it would have to add on completed recipes to the email notification etc.

Comment 4 Blake McIvor 2016-05-23 06:25:05 UTC

https://gerrit.beaker-project.org/#/c/4908/

Comment 7 Dan Callaghan 2016-07-07 23:11:38 UTC

Beaker 23.0 has been released.