| Summary: | Review Request: python-pyrtlsdr - Python binding for librtlsdr | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Jan Synacek <jsynacek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsynacek, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jsynacek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-04 05:23:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jaroslav Škarvada
2016-04-14 08:55:34 UTC
From rpmlint: ... python2-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python2 ... python3-pyrtlsdr.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python3 ... Is this intentional? Those scripts don't look like they are part of the library. If they really are, they probably shouldn't be marked as executable. Otherwise, looks good to me. (In reply to Jan Synacek from comment #1) Thanks for the review. > From rpmlint: > > ... > python2-pyrtlsdr.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python2 > ... > python3-pyrtlsdr.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/rtlsdr/rtlsdrtcp.py 644 /usr/bin/python3 > ... > > Is this intentional? Those scripts don't look like they are part of the > library. If they really are, they probably shouldn't be marked as executable. > Currently the rtlsdrtcp.py is installed non-executable, but it is standalone script - it is a TCP server/client for accessing a device over the network. Thus it is probably better to install it into /usr/bin and make it executable. New version: Spec URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr-0.2.2-2.fc23.src.rpm python2-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.pyc python2-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python2.7/site-packages/rtlsdr/rtlsdrtcp.pyo python3-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/rtlsdr/__pycache__/rtlsdrtcp.cpython-35.pyc python3-pyrtlsdr.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/rtlsdr/__pycache__/rtlsdrtcp.cpython-35.opt-1 You probably want to remove those. New version: Spec URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/python-pyrtlsdr/python-pyrtlsdr-0.2.2-3.fc25.src.rpm Looks ok now. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pyrtlsdr python-pyrtlsdr-0.2.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01 python-pyrtlsdr-0.2.2-3.fc23.1 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce python-pyrtlsdr-0.2.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01 python-pyrtlsdr-0.2.2-3.fc23.1 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce python-pyrtlsdr-0.2.2-3.fc23.1 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-pyrtlsdr-0.2.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |