Bug 1327086

Slavek, how would I go about testing rewheel against a version of pip with this change? While F24 is in Beta Freeze now, it would be good to have the upgraded pip land promptly after the freeze is lifted.

You just need to such version of pip installed systemwide. So either you create an updated local pip RPM or you update pip by pip from PyPI (I'm not 100 % sure, but I *think* this should work as well). I'd advise using mock chroot for testing this :)
If you need more specific info, let me know.

*** Bug 1335134 has been marked as a duplicate of this bug. ***

I changed the BZ title due to pip 8.1.2 just being released upstream.

Created attachment 1158365 [details]
An updated prefix stripping patch

Hi!
Here's my take on it: Upstream now correctly follows PEP 376 [0] by storing paths as relative to the `base location` (usually the `site-packages` directory) iff they are located somewhere under it. That means that we no longer need to strip the prefix of all these paths.

However, this does not affect paths that are not under the `base location`, such as `/usr/bin/`. Therefore this upstream change does not affect our need for the prefix stripping patch.

I have attached an updated prefix stripping patch that will work with the current version of pip (8.1.2) which clears the way for rebasing of the package.

[0] https://www.python.org/dev/peps/pep-0376/#record

Created attachment 1158366 [details]
Patch to update the dist-git of python-pip to 8.1.2, including a new prefix-stripping patch

Alternatively this is a patch for the entire dist-git to update pip to 8.1.2.

Included:

- Update to 8.1.2
- New PyPI URL format
- Updated prefix-stripping patch, which was also renamed so it no longer contains  "pip-1.5rc1" in its name

I should also clarify that prefix stripping for paths such as `/usr/bin/` is necessary because it is used while building the package to strip off the %{buildroot} so that only `/usr/bin` remains.

Lastly, if it would be preferable, I'm glad to do the update myself, but I'll have to ask for ACLs for the python-pip package.

Thanks Tomas, the update looks good to me (I was initially puzzled by the need to switch to files.pythonhosted.org to access the tarball, but I now suspect that's a consequence of the main service switching to Amazon S3 for artifact storage).

I think giving you access to push the update yourself would make sense, so I'll chat with bkabrda about that.

It occurs to me we might want to include a link to https://github.com/pypa/pip/issues/1351 somewhere to explain why we're carrying this patch: while upstream is amenable to a "--stage-dir" option (which we'd set to the RPM build root when invoking pip via macros), there's no actual implementation of that as yet.

In the meantime, the added "--strip-file-prefix" option handles the problem for Fedora (et al), even though upstream don't like that precise name for the option.

bkabrda is also OK with giving you access, so if you submit the ACL request, you'll be able to publish the update yourself.

You are right about the switch to the new URL format, here's further discussion if you are interested: https://bitbucket.org/pypa/pypi/issues/438/backwards-compatible-un-hashed-package

Good idea about the link, it took me a while to figure out what the patch was about since the comments were sparse, I'll include it right away. If they implement it upstream, we can drop our patch for good.

I just got the ACKs, so I'm going to push the update!

Forgot to close the bug since it's only going to rawhide and thus Bodhi won't do it.