Bug 1327309

Summary:	docker-novolume-plugin created an unix socket with a confused name.
Product:	Red Hat Enterprise Linux 7	Reporter:	Qian Cai <qcai>
Component:	docker-latest	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	atomic-bugs <atomic-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.2	CC:	ajia, amurdaca, dwalsh, lsu
Target Milestone:	rc	Keywords:	Extras, ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	docker-1.10.3-19.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-12 14:54:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1303656, 1305185

Description Qian Cai 2016-04-14 18:09:57 UTC

Description of problem:
# /usr/lib/docker-latest/docker-latest-novolume-plugin
# ls /var/run/docker/plugins/
docker-novolume-plugin.sock

It would be better to created a socket called docker-latest-novolume-plugin.sock instead for consistent to match the value passed into /etc/sysconfig/docker-latest conf file. If they don't match, it will error out,

#  docker-latest run -v /:/test fedora sh
docker: Error response from daemon: plugin docker-latest-novolume-plugin failed with error: plugin not found.

Version-Release number of selected component (if applicable):
docker-latest-novolume-plugin-1.10.3-9.el7.x86_64

How reproducible:
always

Comment 2 Lokesh Mandvekar 2016-04-18 16:55:27 UTC

fixed in upcoming ...

Comment 4 Qian Cai 2016-04-19 18:09:35 UTC

Still error out,

# docker-latest info
Error response from daemon: plugin docker-latest-novolume-plugin failed with error: plugin not found

The socket file was created under,
/run/docker-latest/plugins/docker-latest-novolume-plugin.sock

However, docker-latest daemon still look for one under,
/run/docker/

A workaround is,

# ln -s /run/docker-latest/plugins /run/docker/plugins
# docker-latest info
<Working fine.>

Sigh, the plugin directory seems hard-coded to /run/docker since passed -exec-root /run/docker-latest does not help.

Comment 5 Daniel Walsh 2016-05-04 17:34:58 UTC

This package should not exist. There should be no plugins that are called docker-latest.  docker-latest should only change docker code and the docker-storage-setup.

Comment 6 Antonio Murdaca 2016-05-04 17:37:58 UTC

I have an idea why the socket is created in the wrong directory though. Will look more into it later today.

Comment 7 Lokesh Mandvekar 2016-05-04 20:24:35 UTC

(In reply to Daniel Walsh from comment #5)
> This package should not exist. There should be no plugins that are called
> docker-latest.  docker-latest should only change docker code and the
> docker-storage-setup.

Plugin subpackages only have docker- prefixed now.

Comment 8 Daniel Walsh 2016-05-04 20:25:30 UTC

Lets close this as fix now.

Comment 9 Luwen Su 2016-05-05 03:20:02 UTC

Fine to me in docker-latest-1.10.3-22.el7.x86_64

# docker-latest info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 0
Server Version: 1.10.3

# rpm -qa | grep -i novolume-plugin
docker-novolume-plugin-1.10.3-22.el7.x86_64

move to verified

Comment 11 errata-xmlrpc 2016-05-12 14:54:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1057.html