| Summary: | [RFE]enhancement request: support name of container in atomic top | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Alex Jia <ajia> |
| Component: | atomic | Assignee: | Brent Baude <bbaude> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | atomic-bugs <atomic-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.2 | CC: | dwalsh, miabbott |
| Target Milestone: | rc | Keywords: | FutureFeature |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-26 19:08:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Works properly in atomic-1.10. |
Description of problem: When users ran a container w/ name then use atomic top to monitor the running container, atomic stop doesn't work, the image id is okay, but it's not very friendly for users, we should support container name just like atomic run, etc. Version-Release number of selected component (if applicable): [cloud-user@plat-infra-4zpfp3 ~]$ sudo atomic host status TIMESTAMP (UTC) VERSION ID OSNAME REFSPEC * 2016-04-12 14:20:45 7.2.3-1 644fcc6035 rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard 2015-02-19 20:26:26 7.1.0 5799825b36 rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard [cloud-user@plat-infra-4zpfp3 ~]$ rpm -q atomic docker atomic-1.9-4.gitff44c6a.el7.x86_64 docker-1.9.1-25.el7.x86_64 [cloud-user@plat-infra-4zpfp3 ~]$ sudo docker inspect --format='{{.Config.Labels.Version}}-{{.Config.Labels.Release}}' registry.access.redhat.com/rhel7/rsyslog 7.2-21 How reproducible: always Steps to Reproduce: 1. atomic install registry.access.redhat.com/rhel7/rsyslog:latest 2. atomic run -n rsyslog registry.access.redhat.com/rhel7/rsyslog:latest 3. docker ps 4. atomic top rsyslog Actual results: [cloud-user@plat-infra-4zpfp3 ~]$ sudo docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 366df94058cf registry.access.redhat.com/rhel7/rsyslog "/bin/rsyslog.sh" 4 seconds ago Up 3 seconds rsyslog [cloud-user@plat-infra-4zpfp3 ~]$ sudo atomic top -n 2 366df94058cf|grep rsyslogd 366df94058cf rsyslog 11711 0.0 0.3 0 0 /usr/sbin/rsyslogd -n 366df94058cf rsyslog 11711 0.0 0.3 0 0 /usr/sbin/rsyslogd -n [cloud-user@plat-infra-4zpfp3 ~]$ sudo atomic top rsyslog Traceback (most recent call last): File "/bin/atomic", line 525, in <module> sys.exit(_func()) File "/usr/lib/python2.7/site-packages/Atomic/top.py", line 121, in atomic_top proc_info += self.get_pids_by_container(cid) File "/usr/lib/python2.7/site-packages/Atomic/top.py", line 161, in get_pids_by_container con_name = str(next((l for l in self.active_containers if l['Id'].startswith(con_id)), None)['Names'][0]) TypeError: 'NoneType' object has no attribute '__getitem__' Expected results: Additional info: