Bug 1327488

Summary:	RFE: Allow p2v kernel options without p2v.server to set defaults
Product:	[Community] Virtualization Tools	Reporter:	Tom Hughes <tom>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	ptoscano, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-18 14:07:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Tom Hughes 2016-04-15 08:40:12 UTC

I tried adding "p2v.o=libvirt p2v.os=default" to the command line of a p2v entry that I created on our PXE boot server and was surprised that it doesn't seem to work.

Then I read the manual page again and discovered that all those options are ignored unless you fix the server with the p2v.server option.

I don't want to fix the server though - we have (currently) five servers and I want the user to be able to choose which one to use but have it default to creating a machine locally rather than just generating files on local disk.

It seems to me that the vast majority of those options should be accepted anyway to just change the relevant default, though for backwards compatibility I guess you might want a new argument to enable that mode.

Comment 1 Richard W.M. Jones 2016-04-16 21:46:46 UTC

IIUC you want the kernel options to act as defaults for the GUI,
so long as p2v.server isn't specified?  It seems doable.

Comment 2 Tom Hughes 2016-04-16 22:51:24 UTC

Exactly.

Comment 3 Richard W.M. Jones 2016-04-18 14:07:10 UTC

Fixed upstream:
https://github.com/libguestfs/libguestfs/commit/fb74a275c1438e6e0569b7fea85d2a4841a07a4e

Fix will appear in 1.33.23 (dev) / 1.34 (stable).