Bug 1327511 (justinrainbow/json-schema)

Summary: Review Request: php-justinrainbow-json-schema - A library to validate a json schema
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, rcollet, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-13 20:56:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpcompatinfo-full.log
none
phpcompatinfo-lib.log
none
fedora-review.txt none

Description Remi Collet 2016-04-15 09:37:22 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/860d441931f00ed777e626899f61ae511b5a6b33/php/php-justinrainbow-json-schema/php-justinrainbow-json-schema.spec
SRPM URL: http://rpms.remirepo.net/SRPMS/php-justinrainbow-json-schema-2.0.0-1.remi.src.rpm
Description: 
A PHP Implementation for validating JSON Structures against a given Schema.

The validate-json command is provided by the php-JsonSchema package
with the JsonSchema library version 1.x.

See http://json-schema.org/

Autoloader: /usr/share/php/JsonSchema2/autoload.php


Fedora Account System Username: remi

Comment 1 Remi Collet 2016-04-15 09:41:18 UTC
For now, all packages still use the v 1.x, so, only to prepare the future.

This package is designed to be installed beside php-JsonSchema 1.x (perhaps we could consider which one should provide the command).

This package have conditional stuff to obsoletes the old library, when it will not be used anymore.

Comment 2 Remi Collet 2016-04-15 12:41:42 UTC
Koji scatch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13670257

Comment 6 Shawn Iwinski 2016-05-30 02:28:08 UTC
Created attachment 1162644 [details]
phpcompatinfo-full.log

phpCompatInfo version 5.0.0 DB built May 03 2016 08:07:20 CEST

Comment 7 Shawn Iwinski 2016-05-30 02:28:30 UTC
Created attachment 1162645 [details]
phpcompatinfo-lib.log

phpCompatInfo version 5.0.0 DB built May 03 2016 08:07:20 CEST

Comment 8 Shawn Iwinski 2016-05-30 02:29:06 UTC
Created attachment 1162646 [details]
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1327511
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 9 Shawn Iwinski 2016-05-30 02:29:27 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



No blockers.

===== APPROVED =====

Comment 10 Gwyn Ciesla 2016-05-30 16:11:27 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-justinrainbow-json-schema

Comment 11 Fedora Update System 2016-05-31 06:01:44 UTC
php-justinrainbow-json-schema-2.0.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

Comment 12 Fedora Update System 2016-05-31 06:01:51 UTC
php-justinrainbow-json-schema-2.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 13 Fedora Update System 2016-05-31 06:01:57 UTC
php-justinrainbow-json-schema-2.0.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

Comment 14 Fedora Update System 2016-05-31 08:52:45 UTC
php-justinrainbow-json-schema-2.0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 15 Fedora Update System 2016-05-31 20:50:44 UTC
php-justinrainbow-json-schema-2.0.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

Comment 16 Fedora Update System 2016-05-31 20:55:01 UTC
php-justinrainbow-json-schema-2.0.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

Comment 17 Fedora Update System 2016-06-01 08:24:19 UTC
php-JsonSchema-1.6.1-3.fc24 php-justinrainbow-json-schema-2.0.4-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 18 Fedora Update System 2016-06-02 09:01:54 UTC
php-JsonSchema-1.6.1-3.fc24, php-justinrainbow-json-schema-2.0.4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 19 Fedora Update System 2016-06-02 13:28:18 UTC
php-JsonSchema-1.6.1-3.fc24 php-justinrainbow-json-schema-2.0.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 20 Fedora Update System 2016-06-02 13:31:27 UTC
php-justinrainbow-json-schema-2.0.5-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

Comment 21 Fedora Update System 2016-06-02 13:31:44 UTC
php-justinrainbow-json-schema-2.0.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

Comment 22 Fedora Update System 2016-06-03 09:27:55 UTC
php-JsonSchema-1.6.1-3.fc24, php-justinrainbow-json-schema-2.0.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

Comment 23 Fedora Update System 2016-06-03 16:27:44 UTC
php-justinrainbow-json-schema-2.0.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

Comment 24 Fedora Update System 2016-06-03 22:50:57 UTC
php-justinrainbow-json-schema-2.0.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

Comment 25 Fedora Update System 2016-06-13 20:56:04 UTC
php-justinrainbow-json-schema-2.0.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 26 Fedora Update System 2016-06-18 18:54:03 UTC
php-JsonSchema-1.6.1-3.fc24, php-justinrainbow-json-schema-2.0.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2016-06-21 21:49:40 UTC
php-justinrainbow-json-schema-2.0.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.