Bug 1327630

Summary: Invalid network and IP addresses allowed on 2D. Configure Overcloud
Product: Red Hat Quickstart Cloud Installer Reporter: Tasos Papaioannou <tpapaioa>
Component: WebUIAssignee: cchase
Status: CLOSED DEFERRED QA Contact: Tasos Papaioannou <tpapaioa>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.0CC: cchase, ernelson, jmatthew
Target Milestone: TP3   
Target Release: 1.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-25 17:28:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Tasos Papaioannou 2016-04-15 14:03:02 UTC
Description of problem:

On 2D. Configure Overcloud for a RHELOSP deployment, invalid values for the Private Network, Floating IP Network, and Floating IP Network Gateway are allowed. For example, if you accidentally enter '192.0.3.0//24' instead of '192.0.3.0/24' for the private network, there is no warning, and the deployment fails 90.7% through the RHELOSP task:

---
 Error Expected([201]) <=> Actual(400 Bad Request) response => #<Excon::Response:0x0000001031b450 @data={:body=>"{\"NeutronError\": {\"message\": \"Invalid input for cidr. Reason: '192.0.3.0//24' is not a valid IP subnet.\", \"type\": \"HTTPBadRequest\", \"detail\": \"\"}}", :headers=>{"Content-Length"=>"146", "Content-Type"=>"application/json; charset=UTF-8", "X-Openstack-Request-Id"=>"req-f932951b-4be6-4cb3-8a74-c4fd14a06bf8", "Date"=>"Fri, 15 Apr 2016 02:48:38 GMT"}, :status=>400, :remote_ip=>"192.0.2.5", :local_port=>59675, :local_address=>"192.168.0.1"}, @body="{\"NeutronError\": {\"message\": \"Invalid input for cidr. Reason: '192.0.3.0//24' is not a valid IP subnet.\", \"type\": \"HTTPBadRequest\", \"detail\": \"\"}}", @headers={"Content-Length"=>"146", "Content-Type"=>"application/json; charset=UTF-8", "X-Openstack-Request-Id"=>"req-f932951b-4be6-4cb3-8a74-c4fd14a06bf8", "Date"=>"Fri, 15 Apr 2016 02:48:38 GMT"}, @status=400, @remote_ip="192.0.2.5", @local_port=59675, @local_address="192.168.0.1">
---

Other invalid entries that can be entered with no warning include:

For networks:
192.0.3.0/././24
6.6.6.6.6.6.6.6.6//24

For the gateway IP:
6.6.6.6.6.6.6

Version-Release number of selected component (if applicable):

TP3 RC3 QCI-1.0-RHEL-7-20160411.t.0

How reproducible:

100%

Steps to Reproduce:
1.) In OSP deployment, enter an extra slash in the Private network, e.g., 192.0.3.0//24.

2.) Verify that no warning text appears for that field or on the Installation Review tab.

3.) Start deployment and see the RHELOSP progress bar error out at ~91%, with error output like the above.


Actual results:

No warning text for invalid Overcloud network/IP field typos, failed deployment.

Expected results:

Warning if invalid Overcloud network/IP field values are given; unable to submit deployment until valid values are given.

Additional info:

Comment 1 cchase 2016-04-21 19:56:33 UTC
https://github.com/fusor/fusor/pull/780

Fixed the CIDR range validator for floating ip and private networks.

Fixed the IP address validator for the gateway.

Comment 2 John Matthews 2016-04-22 17:21:01 UTC
QCI-1.0-RHEL-7-20160422.t.0-QCI-x86_64-dvd1.iso

Comment 3 Tasos Papaioannou 2016-04-22 20:45:11 UTC
Verified.

Comment 4 Sudhir Mallamprabhakara 2019-02-25 17:28:56 UTC
QCI has sunset. Closing the BZ's