Bug 1327724

Summary: [RFE] Seeing rollback and revert option for snapshot, need to remove the Aliases
Product: Red Hat Ceph Storage Reporter: Tanay Ganguly <tganguly>
Component: RBDAssignee: Jason Dillaman <jdillama>
Status: CLOSED WONTFIX QA Contact: ceph-qe-bugs <ceph-qe-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.0CC: ceph-eng-bugs, hnallurv, jdillama, kdreyer, kurs, tganguly
Target Milestone: rcKeywords: FutureFeature
Target Release: 2.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-10 19:25:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Tanay Ganguly 2016-04-15 18:17:49 UTC
Description of problem:
Seeing rollback and revert option for snapshot, which seems to be same

Version-Release number of selected component (if applicable):
10.1.1.1

How reproducible:
NA

    
[root@cephqe6 ~]# rbd help snap rollback
    usage: rbd snap rollback [--pool <pool>] [--image <image>] [--snap <snap>]
                             [--no-progress]
                             <snap-spec>
     
    Rollback image to snapshot.
     
    Positional arguments
      <snap-spec>          snapshot specification
                           (example: [<pool-name>/]<image-name>@<snapshot-name>)
     
    Optional arguments
      -p [ --pool ] arg    pool name
      --image arg          image name
      --snap arg           snapshot name
      --no-progress        disable progress output
     
[root@cephqe6 ~]# rbd help snap revert
    usage: rbd snap rollback [--pool <pool>] [--image <image>] [--snap <snap>]
                             [--no-progress]
                             <snap-spec>
     
    Rollback image to snapshot.
     
    Positional arguments
      <snap-spec>          snapshot specification
                           (example: [<pool-name>/]<image-name>@<snapshot-name>)
     
    Optional arguments
      -p [ --pool ] arg    pool name
      --image arg          image name
      --snap arg           snapshot name
      --no-progress        disable progress output

Comment 2 Jason Dillaman 2016-04-22 04:24:43 UTC
This was a valid option in RHCS 1.2 and 1.3 -- there are several examples of commands with aliases.  With the new RBD CLI, we denote the alias on the same line as the non-alias within parenthesis:

https://github.com/ceph/ceph/blob/master/src/test/cli/rbd/help.t#L72

Did you think this should be changed to an [RFE] ticket to eliminate all aliases from the rbd CLI?

Comment 3 Jason Dillaman 2016-05-03 11:51:54 UTC
We are not going to be able to remove the aliases (they have existed since before RHCS 2.0).  A contributor did ensure that the help message at least matches the alias when help is requested against the alias.

Upstream PR: https://github.com/ceph/ceph/pull/8698

Comment 5 Tanay Ganguly 2016-05-04 10:11:29 UTC
Jason,
Yes that make sense lets remove all the aliases from RBD CLI, so that there won't be any duplicate command for same operations.

I have modified the BUG Description.

Comment 6 Jason Dillaman 2016-05-04 14:57:06 UTC
If we are changing this to an RFE to remove the aliases, I am going to dev nack it.

Comment 11 Jason Dillaman 2016-08-10 19:25:09 UTC
Aliases have been supported since before RHCS 1.x -- we have no plans to remove them.