Bug 1327866

Description of problem:
Specify a hint according to:

http://docs.openstack.org/developer/ironic/deploy/install-guide.html#specifying-the-disk-for-deployment


It seems that "name" hints will work only for introspection (if at all) -> introspection succeeds and it seems that correct disk gets selected, but when deploying the actual instance, the following happens:

/var/log/ironic/ironic-api.log
InstanceDeployFailure: RPC do_node_deploy failed to validate deploy or power info. Error: The hints "name" are invalid. Valid hints are: "model, wwn, vendor, serial, size"

Version-Release number of selected component (if applicable):
openstack-ironic-api-4.2.2-4.el7ost.noarch

How reproducible:
All the time

Steps to Reproduce:

export IRONIC_DISCOVERD_PASSWORD=`sudo grep admin_password /etc/ironic-inspector/inspector.conf | egrep -v '^#'  | awk '{print $NF}'`


for node in $(ironic node-list | grep -v UUID| awk '{print $2}');

  do swift -U service:ironic -K $IRONIC_DISCOVERD_PASSWORD download ironic-inspector extra_hardware-$node;

done


for f in extra_hardware-*;

  do cat $f | jq -r 'map(select(.[0]=="disk" and .[1]=="vda"))';

done

e.g.:
[stack@undercloud ~]$ cat extra_hardware-6a4546be-7623-4fb8-a913-01b55c5bba01  | jq -r 'map(select(.[0]=="disk" and .[1]=="vda"))';
[
  [
    "disk",
    "vda",
    "size",
    "64"
  ],
  [
    "disk",
    "vda",
    "vendor",
    "0x1af4"
  ],
  [
    "disk",
    "vda",
    "optimal_io_size",
    "0"
  ],
  [
    "disk",
    "vda",
    "physical_block_size",
    "512"
  ],
  [
    "disk",
    "vda",
    "rotational",
    "1"
  ]
]



Specify a hint according to:

http://docs.openstack.org/developer/ironic/deploy/install-guide.html#specifying-the-disk-for-deployment


Attention: "name" hints will work only for introspection

e.g.:

ironic node-update <node-uuid> add properties/root_device='{"name": "/dev/vda"}'

for i in {1..3};do ironic node-update overcloud-ceph$i add properties/root_device='{"name": "/dev/vda"}';done

InstanceDeployFailure: RPC do_node_deploy failed to validate deploy or power info. Error: The hints "name" are invalid. Valid hints are: "model, wwn, vendor, serial, size"

Actual results:
InstanceDeployFailure: RPC do_node_deploy failed to validate deploy or power info. Error: The hints "name" are invalid. Valid hints are: "model, wwn, vendor, serial, size"

Expected results:
success

Additional info: