| Summary: | The logo letters' bottom should consume a bit more space to fully display in Edge 25 and IE 11 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Xingxing Xia <xxia> | ||||||
| Component: | Management Console | Assignee: | Steve Goodwin <sgoodwin> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 3.2.0 | CC: | aos-bugs, jokerman, mmccomas | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | atomic-openshift-3.2.1.3-1.git.0.dfa4ad6.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
A minor formatting issue in the OpenShift Console has been corrected.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-07-05 16:53:15 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Pull request with fix https://github.com/openshift/origin/pull/8799 Commit pushed to master at https://github.com/openshift/origin https://github.com/openshift/origin/commit/f801059a515537f0d4b80c40e51a9b8394d59981 Changes to markup and the logo so that it isn't clipped at certain dimensions - Fixes bug 1328016 - CSS changes to enable logos of varing dimensions within the following sizes - Logo max width 230px / height 36px Created attachment 1155615 [details]
logo_bottom_user_name.png
Tested latest version v1.3.0-alpha.0-418-g38b0157, besides Edge, now Firefox, Chrome also obviously expose the dimension size problem: See Firefox and Chrome snapshot in attchment logo_bottom_user_name.png. The user name "gpojy" bottom is clipped obviously. Commit pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/43bae79da12445fcd274d0854665b375d7049256 Adjust username line height so that descenders aren't clipped. Fix bug 1328016 Please recheck When this bug was reported, there wasn't the username clip problem. Seems comment 2 introduces username clip and comment 5 again fixes it. I am not sure whether the PR will solve the issue of "OPENSHIFT ENTERPRISE" logo letters' bottom (said in above bug description). And, Origin splits out web to origin-web-console git repo, but OSE still has the console code embedded. Seems I cannot test the origin-web-console PR against OSE environment (I didn't find the PR commit in latest OSE puddle with version oc v3.2.0.44, kubernetes v1.2.0-36-g4a3f9c5). (In reply to Steve Goodwin from comment #6) > Please recheck Tested, no the username clip problem after the PR in comment 5. BTW, latest OSE puddle with version openshift v3.2.0.44 still reproduces the issue of "OPENSHIFT ENTERPRISE" logo letters' bottom OSE logo has been updated with https://github.com/openshift/ose/pull/213 please re test Created attachment 1165133 [details]
Examine_IE_via_F12(fail_again)
$ ssh root@<master> /usr/bin/openshift version openshift v3.2.1.1-1-g33fa4ea kubernetes v1.2.0-36-g4a3f9c5 etcd 2.2.5 Checked this latest puddle contains PR #213, but Edge and IE still reproduces. See attachment: Examine_IE_via_F12(fail_again).png. Seems new code does not take effect. Thought it looks ugly for customer, grow it to medium VERIFIED with: openshift v3.2.1.3-1-gcbaf600 kubernetes v1.2.0-36-g4a3f9c5 etcd 2.2.5 Fixed. The logo letters bottom could display fully in Edge 25 and IE 11 (On other browsers, still display well). Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1383 |
Created attachment 1148133 [details] logo-letters-ose-origin Description of problem: On https://<master>/console/ page, the "OPENSHIFT ENTERPRISE" logo letters' bottom should consume a bit more space to fully display in Edge 25 and IE 11. See attachment (Origin is compared with, it has no this issue). No this issue for Firefox, Chrome and Safari Version-Release number of selected component (if applicable): openshift v3.2.0.16 kubernetes v1.2.0-36-g4a3f9c5 etcd 2.2.5 How reproducible: Always Steps to Reproduce: 1. In Windows 10, use Edge or IE, visit https://<master>/console/ to show the "OPENSHIFT ENTERPRISE" logo letters 2. 3. Actual results: 1. The logo letters can be shown, but the bottom is not very fully displayed. Expected results: 1. The logo letters bottom can show fully. Additional info: