Bug 1328167

Summary: ABI changes between libSM-1.2.1-7.el7 and libSM-1.2.2-2.el7 need review
Product: Red Hat Enterprise Linux 7 Reporter: Miroslav Vadkerti <mvadkert>
Component: libSMAssignee: Benjamin Tissoires <btissoir>
Status: CLOSED NOTABUG QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2   
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-18 16:46:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1327619    

Description Miroslav Vadkerti 2016-04-18 15:24:24 UTC
Description of problem:

This package is showing ABI changes which need your attention. Note that this package is on ABI compatibility list [1] in level 2. The ABI changes were tested using libabigail - abipkgdiff [2], only for subpackage:

    libSM

See

    http://gov-cert.brq.redhat.com/abidiff/results/level2_72vs70/72vs70_libSM-1.2.1-7.el7_vs_libSM-1.2.2-2.el7_libSM.txt

for detailed results from the scan. Note that the results are merged for all architectures, thus there can be some duplicity.

To reproduce the issue run the abipkgdiff on the reported package libSM:

    $ abipkgdiff --d1 OLD_DEBUGINFO --d2 NEW_DEBUGINFO OLD_RPM NEW_RPM

See the tool documentation for more information [2].

***What is action is required from the assignee of this bugzilla?***

Please review the results and, in the case of a bug, resolve the ABI breakage ASAP in the next RHEL-7 release. In the case that all ABI changes are expected, please close this bugzilla as NOTABUG. 

Version-Release number of selected component (if applicable):
libSM-1.2.2-2.el7

How reproducible:
100%

Actual results:
http://gov-cert.brq.redhat.com/abidiff/results/level2_72vs70/72vs70_libSM-1.2.1-7.el7_vs_libSM-1.2.2-2.el7_libSM.txt

Expected results:
No issues or all issues expected (after your review)

Additional info:
[1] https://access.redhat.com/sites/default/files/attachments/rhel7_app_compatibility_wp.pdf
[2] https://sourceware.org/libabigail/manual/abipkgdiff.html

Comment 1 Miroslav Vadkerti 2016-04-18 15:36:04 UTC
 *** Please, when closing bug as NOTABUG, provide a short justification ****

Comment 3 Benjamin Tissoires 2016-04-18 16:46:24 UTC
See upstream commit that introduced the change:
https://cgit.freedesktop.org/xorg/lib/libSM/commit/include/X11/SM/SMlib.h?id=759bbd43f0fdc9a96ba1676d7830164bc9954be2

GCC was already complaining about the missing const. Not to mention that the previousId argument should not be changed by SmcOpenConnection().

Closing as NOTABUG