Bug 1328233
Summary: | Switch catfish to Python 3 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mairi Dulaney <jdulaney> | ||||||
Component: | catfish | Assignee: | Mamoru TASAKA <mtasaka> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 25 | CC: | dkrejci, jdulaney, lbalhar, masahase, mhroncok, mtasaka, torsava | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | catfish-1.4.2-2.fc26 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2016-08-17 13:22:23 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1285816, 1312032 | ||||||||
Attachments: |
|
Description
Mairi Dulaney
2016-04-18 19:17:16 UTC
Created attachment 1148285 [details]
0001-Remove-unnecessary-shebangs.patch
Noticed that there were a few stray shebangs that are unnecessary and cause rpmlint errors; this patch removes them.
Created attachment 1148286 [details]
catfish.spec
Updated spec file that builds the python3 variant
I note that I also removed the Group tag from the spec file, as that is no longer needed. Scratch build can be found here: http://koji.fedoraproject.org/koji/taskinfo?taskID=13703695 (In reply to John Dulaney from comment #1) > Created attachment 1148285 [details] > 0001-Remove-unnecessary-shebangs.patch > > Noticed that there were a few stray shebangs that are unnecessary and cause > rpmlint errors; this patch removes them. Maybe do it with sed in spec, so it dos not have to be rebased with new releases? http://python-rpm-porting.readthedocs.io/en/latest/applications.html#fixing-shebangs Hi John! Thank you for taking the time to make patch for Python 3! However, the required practice is that stray shebangs have to be removed in some automatic way—preferably using the `sed` tool. You can read detailed instructions on how to do it in the Python RPM Porting Guide, section on Shebangs [0]. The patch you posted that removes the shebangs will only work on the current version of the source code, so with every release the packager might have to made a new patch, which is why this way is ill advised. [0] http://python-rpm-porting.readthedocs.io/en/latest/applications.html#fixing-shebangs Thank you very much for your time! This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Hi. Is there any problem with adding `sed` to specfile? Can I help you with something? Do not hesitate to contact me for any help. * Wed Aug 17 2016 Mamoru TASAKA <mtasaka> - 1.4.2-2 - Support python3 for F-25+ (only) |