Bug 1328313

Summary:	bkr group-modify accepts multiple --add-member options but then ignores all but the last one
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	command line	Assignee:	Blake McIvor <bmcivor>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	bmcivor, dcallagh, dowang, mjia, rjoost
Target Milestone:	23.0	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1336966 (view as bug list)		Environment:
Last Closed:	2016-07-07 23:09:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1336966

Description Dan Callaghan 2016-04-19 04:08:24 UTC

Version-Release number of selected component (if applicable):
22.3

Steps to Reproduce:
1. bkr group-modify --add-member=tflink --add-member=dcallagh admin

Actual results:
Only dcallagh is added to admin group.

Expected results:
Both dcallagh and tflink should be added to admin group.

Additional info:
The --help output is also not great, maybe fix that at the same time.

Comment 1 matt jia 2016-05-17 22:58:00 UTC

Same for --remove-member option. The command should be able to remove multiple members all at once.

Comment 2 Blake McIvor 2016-05-19 02:31:55 UTC

https://gerrit.beaker-project.org/#/c/4899/

Comment 3 Blake McIvor 2016-05-23 00:52:32 UTC

https://gerrit.beaker-project.org/#/c/4907/

updated patch-set to include https://bugzilla.redhat.com/show_bug.cgi?id=1336966

Comment 4 Blake McIvor 2016-05-24 01:09:49 UTC

one last time, i hope

https://gerrit.beaker-project.org/#/c/4920/

Comment 5 matt jia 2016-06-06 06:33:50 UTC

This bug fix is in beaker-client-23.0-0.git.218.8795dde which is available for download here:

https://beaker-project.org/nightlies/develop/

Comment 9 Blake McIvor 2016-06-07 06:54:48 UTC

why didn't I think of that

https://gerrit.beaker-project.org/#/c/4963/1

Comment 10 Dan Callaghan 2016-06-20 04:51:48 UTC

This bug fix is included in beaker-client-23.0-0.git.246.f3459e8 which is currently available for download here:

https://beaker-project.org/nightlies/develop/

Comment 12 Dan Callaghan 2016-07-07 23:09:43 UTC

Beaker 23.0 has been released.