Bug 1328383

Summary: VM with a direct lun doesn't start with libvirt >= 1.3.2
Product: [oVirt] vdsm Reporter: Pavel Gashev <pax>
Component: CoreAssignee: Francesco Romani <fromani>
Status: CLOSED DUPLICATE QA Contact: Aharon Canan <acanan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.17.23CC: bugs, fromani, michal.skrivanek
Target Milestone: ---Flags: rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-19 11:42:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Gashev 2016-04-19 09:27:46 UTC 
Description of problem:
VM doesn't start with attached Direct LUN. Vdsm.log shows the following error:
libvirtError: unsupported configuration: Disks 'hdc' and 'sda' have identical serial

Version-Release number of selected component (if applicable):
libvirt-daemon-1.3.2
vdsm-4.17.23.2

How reproducible:
Start a VM with attached Direct LUN.

Cause:
It looks like the same case as https://bugzilla.redhat.com/1322842

Part of domain config:
<disk device="cdrom" snapshot="no" type="file">
    <address bus="1" controller="0" target="0" type="drive" unit="0"/>
    <source file="" startupPolicy="optional"/>
    <target bus="ide" dev="hdc"/>
    <readonly/>
    <serial/>
</disk>
<disk device="disk" snapshot="no" type="file">
    <address bus="0x00" domain="0x0000" function="0x0" slot="0x05" type="pci"/>
    <source file="/rhev/data-center/00000001-0001-0001-0001-00000000029b/bbcc9361-fc4f-4f40-949a-beae401ff27d/images/4a717fab-db0a-4976-af46-c2cc237c5dd5/9f2f1a9a-6b9c-43b4-822c-245314cfa300"/>
    <target bus="virtio" dev="vda"/>
    <serial>4a717fab-db0a-4976-af46-c2cc237c5dd5</serial>
    <boot order="1"/>
    <driver cache="none" error_policy="stop" io="threads" name="qemu" type="raw"/>
</disk>
<disk device="disk" snapshot="no" type="block">
    <address bus="0" controller="0" target="0" type="drive" unit="2"/>
    <source dev="/dev/mapper/3600508b1001cc80d438352f93eb0385d"/>
    <target bus="scsi" dev="sda"/>
    <serial/>
    <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/>
</disk>
Comment 1 Michal Skrivanek 2016-04-19 11:27:15 UTC 
can you please review and close if indeed the same issue already solved?
Comment 2 Francesco Romani 2016-04-19 11:42:59 UTC 
(In reply to Pavel Gashev from comment #0)
> Description of problem:
> VM doesn't start with attached Direct LUN. Vdsm.log shows the following
> error:
> libvirtError: unsupported configuration: Disks 'hdc' and 'sda' have
> identical serial
> 
> Version-Release number of selected component (if applicable):
> libvirt-daemon-1.3.2
> vdsm-4.17.23.2
> 
> How reproducible:
> Start a VM with attached Direct LUN.
> 
> Cause:
> It looks like the same case as https://bugzilla.redhat.com/1322842

Yes, It should be fixed by the same patch, because once again we should not send empty serial to libvirt: either full serial, or no serial at all, and this applies also to LUN. So the codepath is the same.

Please reopen if doesn't work even after 1322842 is fixed.

*** This bug has been marked as a duplicate of bug 1322842 ***