Bug 1328803

Summary: rebase-helper fails to download sources when URL contains # character
Product: [Fedora] Fedora Reporter: Petr Spacek <pspacek>
Component: rebase-helperAssignee: Petr Hracek <phracek>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: phracek, thozza
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-20 20:03:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Petr Spacek 2016-04-20 10:18:10 UTC
Description of problem:
rebase-helper fails to download sources when URL contains # character, which is typically the case when copy&pasting links from PyPi.

Version-Release number of selected component (if applicable):
rebase-helper-0.7.3-1.fc23.noarch

How reproducible:
100 %

Steps to Reproduce:
1. fedpkg clone python-ldap
2. cd python-ldap
3. rebase-helper 'https://pypi.python.org/packages/9b/1a/f2bc7ebf2f0b21d78d7cc2b5c283fb265397912cd63c4b53c83223ebcac9/python-ldap-2.4.25.tar.gz#md5=21523bf21dbe566e0259030f66f7a487'

Actual results:
$ rebase-helper 'https://pypi.python.org/packages/9b/1a/f2bc7ebf2f0b21d78d7cc2b5c283fb265397912cd63c4b53c83223ebcac9/python-ldap-2.4.25.tar.gz#md5=21523bf21dbe566e0259030f66f7a487'
Results directory 'rebase-helper-results' exists, removing it
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
warning: bogus date in %changelog: Tue May 15 2006 Matthew Barnes <mbarnes> - 2.2.0-1
Workspace directory 'rebase-helper-workspace' exists, removing it
Traceback (most recent call last):
  File "/bin/rebase-helper", line 9, in <module>
    load_entry_point('rebasehelper==0.7.3', 'console_scripts', 'rebase-helper')()
  File "/usr/lib/python2.7/site-packages/rebasehelper/cli.py", line 148, in run
    app.run()
  File "/usr/lib/python2.7/site-packages/rebasehelper/application.py", line 655, in run
    sources = self.prepare_sources()
  File "/usr/lib/python2.7/site-packages/rebasehelper/application.py", line 358, in prepare_sources
    os.path.join(self.execution_dir, settings.NEW_SOURCES_DIR))
  File "/usr/lib/python2.7/site-packages/rebasehelper/application.py", line 322, in extract_sources
    Application.extract_archive(archive_path, destination)
  File "/usr/lib/python2.7/site-packages/rebasehelper/application.py", line 313, in extract_archive
    archive.extract_archive(destination)
  File "/usr/lib/python2.7/site-packages/rebasehelper/archive.py", line 275, in extract_archive
    archive = self._archive_type.open(self._filename)
  File "/usr/lib/python2.7/site-packages/rebasehelper/archive.py", line 151, in open
    return tarfile.TarFile.open(filename)
  File "/usr/lib64/python2.7/tarfile.py", line 1678, in open
    raise ReadError("file could not be opened successfully")
tarfile.ReadError: file could not be opened successfully


Expected results:
It should not blow up :-)

Additional info:
It downloaded two files:
	python-ldap-..tar.gz
	python-ldap-.python.tar.gz

Comment 1 Tomáš Hozza 2016-04-20 12:34:34 UTC
(In reply to Petr Spacek from comment #0)
> Description of problem:
> rebase-helper fails to download sources when URL contains # character, which
> is typically the case when copy&pasting links from PyPi.
> 
> Version-Release number of selected component (if applicable):
> rebase-helper-0.7.3-1.fc23.noarch
> 
> How reproducible:
> 100 %
> 
> Steps to Reproduce:
> 1. fedpkg clone python-ldap
> 2. cd python-ldap
> 3. rebase-helper
> 'https://pypi.python.org/packages/9b/1a/
> f2bc7ebf2f0b21d78d7cc2b5c283fb265397912cd63c4b53c83223ebcac9/python-ldap-2.4.
> 25.tar.gz#md5=21523bf21dbe566e0259030f66f7a487'

Rebase-helper expects just version or downloaded tarball, not URL. The described usage is not supported, but I agree it should not blow up :)

Comment 2 Petr Hracek 2016-07-26 12:57:15 UTC
Upstream tracker bug https://github.com/rebase-helper/rebase-helper/issues/212

Comment 3 Fedora End Of Life 2016-11-25 07:24:45 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2016-12-20 20:03:12 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.