| Summary: | UI - show.html.erb error on accessing compute resource details on RHEL6.7 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Roman Plevka <rplevka> | ||||
| Component: | Provisioning | Assignee: | Marek Hulan <mhulan> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Roman Plevka <rplevka> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.2.0 | CC: | bbuckingham, mhulan, mmccune | ||||
| Target Milestone: | Unspecified | Keywords: | Triaged | ||||
| Target Release: | Unused | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://projects.theforeman.org/issues/14769 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | foreman-1.11.0.17-1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-07-27 10:59:13 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Roman Plevka
2016-04-20 13:12:37 UTC
Created attachment 1149093 [details]
CR error
It's one of foreman_docker override that breaks this page, it adds <%= a unless b %>, statement modifiers do not work in loud erb tags It seems more complicated, as a workaround either uninstall foreman_docker or comment second definition in /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_docker-2.0.1.4/app/overrides/remove_docker_from_compute_profiles.rb Created redmine issue http://projects.theforeman.org/issues/14769 from this bug Upstream bug assigned to stbenjam Upstream bug component is Container Management Upstream bug assigned to mhulan Upstream bug component is Provisioning Moving to POST since upstream bug http://projects.theforeman.org/issues/14769 has been closed ------------- Marek Hulán TL;DR: EL6 contains old libxml2/libxslt which can cause problems when using deface on a template that contains comment like <% #this %> Longer version: After many hours spent on debugging I realized that the issue is that when action view compiles the template, some lines are concatenated together just split by ";". This becomes problem when ERB tag contained commentary symbol #. The reason is that when deface override is applied it first converts the template to tree using Nokogiri (see "Parser.convert":https://github.com/DefaceCommunity/deface/blob/master/lib/deface/parser.rb#L106). This returns different results on different versions of underlying library. I didn't try to compile different versions but with libxml2-2.7.6-20.el6.x86_64 and libxslt-1.1.26-2.el6_3.1.x86_64 it does not wrap the silent erb tag with "\n" so as a result, this tag ends up on the same line as previous one. The same nokogiri but on newer lib versions (libxml2-2.9.1-5.el7_1.2.x86_64, libxslt-1.1.28-5.el7.x86_64) wrapped it. I know that right solution would be to update libraries in EL6 or ship it ourselves but this seems much more complicated process than just removing the comment line which does not have a big value anyway. It seems to be only comment in our templates. If we agree on this as a solution it's a fix in core, so moving back to Foreman. ------------- Marek Hulán Applied in changeset commit:d46b64a2e8debb5298bf58f1941ef3204e401735. VERIFIED on sat 6.2.0 snap 9.2 - the page now loads without errors on rhel 6.7. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501 |