Bug 1328994

Summary:	When a feature fails needing a higher opversion, the message should state what version it needs.
Product:	[Community] GlusterFS	Reporter:	Joe Julian <joe>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	amukherj, bugs, kaushal, sbairagy, smohan
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-08 17:31:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joe Julian 2016-04-20 20:23:28 UTC

When a command fails because a feature is not supported in the current op-version, the required op-version should be stated so the user can know what op-version is required to support it.

Comment 1 Kaushal 2017-03-08 10:48:49 UTC

This bug is getting closed because GlusteFS-3.7 has reached its end-of-life.

Note: This bug is being closed using a script. No verification has been performed to check if it still exists on newer releases of GlusterFS.
If this bug still exists in newer GlusterFS releases, please reopen this bug against the newer release.

Comment 2 Atin Mukherjee 2017-08-10 07:49:36 UTC

root@ea99bb4a9e09:/home/glusterfs# gluster v set all cluster.localtime-logging enable
volume set: failed: Staging failed on 172.17.0.3. Error: Required op_version (31200) is not supported
root@ea99bb4a9e09:/home/glusterfs# gluster v get all cluster.op-version
Option                                  Value                                   
------                                  -----                                   
cluster.op-version                      31000                                   
root@ea99bb4a9e09:/home/glusterfs# 

With current mainline code, this is working as per expectation.

Comment 3 Joe Julian 2017-08-10 15:42:51 UTC

You've now got the code to finish this, why not make the call internally and so make the error read:

volume set: failed: Staging failed on 172.17.0.3. Error: Required op_version (31200) is not supported. Max supported op_version is 31000.

This makes the error useful and does not put the onus on the user to know how to get that information.

Comment 4 Worker Ant 2017-08-11 04:52:07 UTC

REVIEW: https://review.gluster.org/18020 (glusterd: improve op-version error message) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 5 Atin Mukherjee 2017-08-11 04:53:45 UTC

(In reply to Joe Julian from comment #3)
> You've now got the code to finish this, why not make the call internally and
> so make the error read:
> 
> volume set: failed: Staging failed on 172.17.0.3. Error: Required op_version
> (31200) is not supported. Max supported op_version is 31000.
> 
> This makes the error useful and does not put the onus on the user to know
> how to get that information.

Thanks Joe, posted a patch.

Comment 6 Worker Ant 2017-08-16 17:02:52 UTC

COMMIT: https://review.gluster.org/18020 committed in master by Atin Mukherjee (amukherj) 
------
commit 204d52a4b6c13d16132f67ee94f823fa23c11538
Author: Atin Mukherjee <amukherj>
Date:   Fri Aug 11 10:20:14 2017 +0530

    glusterd: improve op-version error message
    
    In case of a heterogeneous cluster if an admin sets a volume option
    which is higher than the current op-version the current error message
    only displays the version number of the new tunable. Better use
    experience is to dump the supported op-version in the error message as
    well.
    
    Change-Id: Ib42dadc574a401f79364178cb41ad21fb0b4432b
    BUG: 1328994
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/18020
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Joe Julian <me>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>

Comment 7 Shyamsundar 2017-12-08 17:31:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/