Bug 1329232

Summary: [SPEC] add systemd-journal-upload user to systemd-journal group
Product: Red Hat Enterprise Linux 7 Reporter: Lukáš Nykrýn <lnykryn>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Branislav Blaškovič <bblaskov>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.2CC: bblaskov, systemd-maint-list, systemd-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-219-27.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-04 00:53:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukáš Nykrýn 2016-04-21 13:14:08 UTC
--- systemd.spec.original	2015-09-14 11:43:11.031573973 +0900
+++ systemd.spec.original	2015-09-14 17:59:25.122998461 +0900
@@ -499,7 +499,7 @@ 
 getent group systemd-journal-remote >/dev/null 2>&1 || groupadd -r systemd-journal-remote 2>&1 || :
 getent passwd systemd-journal-remote >/dev/null 2>&1 || useradd -r -l -g systemd-journal-remote -d /%{_localstatedir}/log/journal/remote -s /sbin/nologin -c "Journal Remote" systemd-journal-remote >/dev/null 2>&1 || :
 getent group systemd-journal-upload >/dev/null 2>&1 || groupadd -r systemd-journal-upload 2>&1 || :
-getent passwd systemd-journal-upload >/dev/null 2>&1 || useradd -r -l -g systemd-journal-upload -d /%{_localstatedir}/log/journal/upload -s /sbin/nologin -c "Journal Upload" systemd-journal-upload >/dev/null 2>&1 || :
+getent passwd systemd-journal-upload >/dev/null 2>&1 || useradd -r -l -g systemd-journal-upload -G systemd-journal -d /%{_localstatedir}/log/journal/upload -s /sbin/nologin -c "Journal Upload" systemd-journal-upload >/dev/null 2>&1 || :
 
 %post journal-gateway
 %systemd_post systemd-journal-gatewayd.socket systemd-journal-gatewayd.service

Comment 1 Branislav Blaškovič 2016-04-21 13:23:12 UTC
qa acking

Comment 4 Branislav Blaškovič 2016-07-27 14:25:28 UTC
I am afraid this somehow got lost between .22 and .24.

:: [ 15:25:21 ] :: Package versions:
:: [ 15:25:21 ] ::   systemd-219-24.el7.x86_64
:: [ 10:15:27 ] :: Package versions:
:: [ 10:15:28 ] ::   systemd-journal-gateway-219-24.el7.x86_64
...
:: [  BEGIN   ] :: Running 'grep '^systemd-journal:' /etc/group'
systemd-journal:x:190:
:: [   PASS   ] :: Command 'grep '^systemd-journal:' /etc/group' (Expected 0, got 0)

Can you please take a look at it?


See:
https://beaker.engineering.redhat.com/jobs/1419233
http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2016/07/14192/1419233/2906226/43615921/TESTOUT.log

Comment 5 Lukáš Nykrýn 2016-07-28 13:05:06 UTC
Add addgroup systemd-journal to systemd-journal-remote package

Comment 6 Lukáš Nykrýn 2016-08-19 08:52:06 UTC
Fixed in 219-27

Comment 7 Branislav Blaškovič 2016-09-13 10:36:03 UTC
Great it works fine with -29. See below.

NEW PACKAGE:
:: [   LOG    ] :: Package versions:
:: [   LOG    ] ::   systemd-219-29.el7.x86_64
:: [   PASS   ] :: Command 'grep '^systemd-journal:' /etc/group' (Expected 0, got 0)
:: [   PASS   ] :: File '/var/tmp/tmp.icvFyvLhBl' should contain 'systemd-journal-upload'
:: [   LOG    ] :: Duration: 1s
:: [   LOG    ] :: Assertions: 2 good, 0 bad
:: [   PASS   ] :: RESULT: Test

OLD PACKAGE:
:: [   LOG    ] :: Package versions:
:: [   LOG    ] ::   systemd-219-19.el7.x86_64
:: [   PASS   ] :: Command 'grep '^systemd-journal:' /etc/group' (Expected 0, got 0)
:: [   FAIL   ] :: File '/var/tmp/tmp.w4Dl8CrvJX' should contain 'systemd-journal-upload'
:: [   LOG    ] :: Duration: 1s
:: [   LOG    ] :: Assertions: 1 good, 1 bad
:: [   FAIL   ] :: RESULT: Test

Comment 9 errata-xmlrpc 2016-11-04 00:53:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2216.html