| Summary: | Catalog content has quick-start as instant-appp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Online | Reporter: | Steve Speicher <sspeiche> | ||||
| Component: | Templates | Assignee: | Dan Mace <dmace> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | XiuJuan Wang <xiuwang> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.x | CC: | aos-bugs, dmace, gmontero, jokerman, mmccomas | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-06-23 17:32:17 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
I'll take this one. The way we include the templates in Online currently relies on wildcards with a blacklist, which lets new unapproved templates creep in. We should switch the template script to use a whitelist. Adding Gabe so he can review the work. Will be fixed with https://github.com/openshift/online/pull/115 In case it wasn't understood, the "nodejs-helloworld-sample" is the application sample included with the jenkins instant app. Literally, the associated template is https://github.com/openshift/origin/blob/master/examples/jenkins/application-template.json This template fuels the sample job included in the OpenShift Jenkins image. Without this template, users will not be able to use the sample job. Steve - are you comfortable with that? Check in dev-preview-stg (openshift master:v3.2.0.44). Only jenkins-persistent template is in 'Instant Apps' catalog. Move bug to verified. |
Created attachment 1149837 [details] screenshot Description of problem: Currently only see 2, need to remove nodejs-helloworld-sample Version-Release number of selected component (if applicable): hosted dev-preview-int.openshift.com OpenShift Master: v3.2.0.16 Kubernetes Master: v1.2.0-36-g4a3f9c5 How reproducible: Got to "Add to project" and observe "instant-app" content Steps to Reproduce: 1. See above and screenshot Actual results: 2 quick starts Expected results: only 1 quick start (jenkins) Additional info: