Bug 1329815

Summary: get_security_context hardcodes "system_u" SELinux user
Product: [Fedora] Fedora Reporter: Gary Tierney <gary.tierney>
Component: cronieAssignee: Tomas Mraz <tmraz>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: mmaslano, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-20 20:06:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
PATCH none

Description Gary Tierney 2016-04-23 12:31:32 UTC 
Created attachment 1149996 [details]
PATCH

Description of problem:

When cronie tries to resolve a security_context for system cronjobs to run under it makes the assumption that the "system_u" user will exist. In cases where a custom policy is used this might not be the case (seeing issues with DSSP policy that instead uses a system user labeled as "sys.id") and cronie will fail to get a context.

The patch included instead assumes that cronie is currently running as the system user, and gets the user of the current context. This preserves the current behavior with upstream selinux-policy and ensures that system jobs are still started under "system_u" and also fixes the case for custom policy.

Version-Release number of selected component (if applicable):

git-master

How reproducible:

Replace references to "system_u" in the upstream policy with another user and cronie will fail to start system cronjobs. 

It is rather tedious to reproduce this problem on a stock system as it requires changing much of the policy, but the DSSP live image (Fedora rawhide) is currently seeing this issue: http://tfirg.asu.su/wp-content/uploads/2016/04/FedoraLive-1.iso

Steps to Reproduce:
1. Change references from "system_u" to another user in policy
2. Load modified policy
3. Relabel filesystem and and restart crond

Actual results:

get_security_context fails

Expected results:

get_security_context returns a context with the user of crond's own context
Comment 1 Fedora End Of Life 2016-11-25 07:27:16 UTC 
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 2 Fedora End Of Life 2016-12-20 20:06:51 UTC 
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.