Bug 1329954

Summary: Bond can not click to on after created through cockpit
Product: Red Hat Enterprise Linux 7 Reporter: wanghui <huiwa>
Component: cockpitAssignee: Dominik Perpeet <dperpeet>
Status: CLOSED ERRATA QA Contact: Jan Ščotka <jscotka>
Severity: high Docs Contact:
Priority: urgent    
Version: 7.2CC: bugs, cshao, fdeutsch, gklein, huzhao, leiwang, rbarry, stefw, weiwang, yaniwang, ycui, ykaul
Target Milestone: pre-dev-freezeKeywords: Extras
Target Release: 7.2   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: cockpit-0.114-2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-04 13:46:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1329957    

Description wanghui 2016-04-25 08:05:35 UTC
Description of problem:
After configured bond in cockpit, the bond can not be check to on. And there is no save button for us to save the changes in "General" field.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Anaconda install NGN 4.0.
2. Start cockpit service.
3. Configue bond with mode "Round Robin".
4. Check "On" button in cockpit.
5. Check the 'General' field to enable connect automatically.
6. Check the members field.

Actual results:
1. After step4, the 'On' button can not be checked.
2. After step5, miss save button to save the changes in "General" field. 
3. After step6, the members can be configured individually.

Expected results:
1. Bond can be up after configured in cockpit.
2. Since bond is a new bridge to treat all nics as slaves, it should not let the salves to be configured individually.

Additional info:

Comment 1 Fabian Deutsch 2016-04-25 08:25:15 UTC
Please try to reproduce this on RHEL. You will need to enable RHEL extras to retrieve cockpit.

Comment 2 wanghui 2016-04-26 09:52:44 UTC
Since this issue is move to cockpit part, I would like to wait cockpit guys to debug this issue.

Comment 4 Fabian Deutsch 2016-05-24 14:27:33 UTC
Wei, does this mean a bond can not be enabled and be saved?

Comment 5 wanghui 2016-05-26 04:44:29 UTC
(In reply to Fabian Deutsch from comment #4)
> Wei, does this mean a bond can not be enabled and be saved?

yes, the enable button for bond can not be clicked.

Comment 6 Marius Vollmer 2016-06-27 11:06:46 UTC
Please also state the version of NetworkManager.

Comment 7 Marius Vollmer 2016-06-27 11:27:11 UTC
> After step5, miss save button to save the changes in "General" field. 

There is no need to explicitly save this setting.  It will be saved as soon as you change it.

Comment 8 Marius Vollmer 2016-06-27 11:56:13 UTC
> yes, the enable button for bond can not be clicked.


What I can observe:

- Switching off a bond will also switch off all slaves.
- Switching on a bond whose slaves are all off will do nothing.  (This is the bug.)
- Switching off all slaves of a bond will keep the bond on.
- Switching on a slave of a bond that is off will switch on the bond as well.

Using nmcli to activate a bond connection whose slaves are all off does successfully activate the bond.  One needs to also explicitly switch on the slaves, however.  This is what should happen with Cockpit also and I'll fix that.

Whether or not activating a bond connection should connect the slaves a well... This looks like something that NetworkManager should decide and take care off.  We want this to be consistent between Cockpit and nmcli, for example, and I'll make sure that Cockpit matches nmcli.  If you are unhappy with the behavior of nmcli, please file a bug against NetworkManager.

(I have observed different behavior on different OSes at different times and can't figure out the pattern.  That's why I kept all the individual slave on/off buttons in the UI.  They seem to be necessary since NetworkManager does not seem to manage the slaves well enough.  I guess we need to revisit that also.)

Comment 9 Marius Vollmer 2016-06-27 13:17:31 UTC

Turns out the on/off switch was erroneously disabled, but this wasn't reflected in its looks.

So, two bugs:

 - the on/off switch should not be disabled for inactive bonds.
 - the on/off switch should actually _look_ disabled when it _is_ disabled.

Both are fixed in the linked pull request.

Comment 11 Stef Walter 2016-07-05 19:20:25 UTC
This bug will be fixed in cockpit 0.113


Reassigning to Dominik for inclusion in next RHEL release of Cockpit.

Comment 16 errata-xmlrpc 2016-08-04 13:46:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.