Bug 1329956

Summary:	vlan can not click to on after created through cockpit and the original nic still can be configured
Product:	Red Hat Enterprise Linux 7	Reporter:	wanghui <huiwa>
Component:	cockpit	Assignee:	Dominik Perpeet <dperpeet>
Status:	CLOSED ERRATA	QA Contact:	Jan Ščotka <jscotka>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	7.2	CC:	bugs, cshao, fdeutsch, gklein, huzhao, leiwang, rbarry, stefw, weiwang, yaniwang, ycui, ykaul
Target Milestone:	pre-dev-freeze	Keywords:	Extras
Target Release:	7.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-0.114-2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-04 13:47:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1329957

Description wanghui 2016-04-25 08:10:45 UTC

Description of problem:
vlan can not click to on after created through cockpit and the original nic still can be configured

Version-Release number of selected component (if applicable):
ovirt-node-ng-installer-ovirt-3.6-2016042323.iso 
cockpit-0.103-1.el7.centos.x86_64
cockpit-ovirt-0.5.1-0.0.master.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Anaconda install NGN 4.0.
2. Start cockpit service.
3. Add a vlan in p3p1
4. Check "On" button for p3p1.20 in cockpit.
5. Check the 'General' field to enable connect automatically.
6. Check the networking field.

Actual results:
1. After step4, the 'On' button can not be checked.
2. After step5, miss save button to save the changes in "General" field. 
3. After create vlan, p3p1 still in interfaces list and can be configured also.

Expected results:
1. After step4, the "on" button can be checked.
2. After step5, the changes can be saved in "General" field.
3. p3p1 can not be configured.

Additional info:

Comment 1 Fabian Deutsch 2016-04-25 08:25:23 UTC

Please try to reproduce this on RHEL. You will need to enable RHEL extras to retrieve cockpit.

Comment 2 wanghui 2016-04-26 09:52:48 UTC

Since this issue is move to cockpit part, I would like to wait cockpit guys to debug this issue.

Comment 4 Marius Vollmer 2016-06-27 13:30:24 UTC

https://github.com/cockpit-project/cockpit/pull/4640

This is fixed by the same fix as bug 1329954.

VLAN devices also had a disabled on/off switch in their off state because the actual kernel interface does not exist then.

Comment 5 Marius Vollmer 2016-06-28 12:35:21 UTC

> After step5, miss save button to save the changes in "General" field. 

There is no need to save this explicitly, it will be saved when you change it.

Comment 6 Marius Vollmer 2016-06-28 12:36:50 UTC

> After create vlan, p3p1 still in interfaces list and can be configured also.

Could you file a new bug for this separate issue?

Could you also explain why the parent of a vlan should not be configured individually?

Comment 8 Stef Walter 2016-07-05 19:19:19 UTC

This bug will be fixed in cockpit 0.113

https://github.com/cockpit-project/cockpit/pull/4640

Comment 9 Stef Walter 2016-07-05 19:19:56 UTC

Reassigning to Dominik for inclusion in next RHEL release of Cockpit.

Comment 11 Stef Walter 2016-07-14 12:23:46 UTC

Cockpit integration test here: https://github.com/cockpit-project/cockpit/pull/4640/files#diff-b7a8b7371f34d5364bc2f57a5d9c812aR224

Comment 14 errata-xmlrpc 2016-08-04 13:47:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1442.html